Add JSON ingestion indexing extensions#1204
Open
jwils wants to merge 1 commit into
Open
Conversation
7bc0045 to
6267113
Compare
024c4ef to
d8c3c70
Compare
040cea2 to
e6a4787
Compare
d8c3c70 to
b78686f
Compare
e6a4787 to
eb21230
Compare
b78686f to
0b3844f
Compare
0b3844f to
65f9a60
Compare
eb21230 to
2afdcd4
Compare
65f9a60 to
6be803f
Compare
b03c1a4 to
a3171ef
Compare
159afa8 to
29e7e8e
Compare
bf0dd3b to
34a576b
Compare
31d7828 to
87c88c1
Compare
34a576b to
5920f3b
Compare
87c88c1 to
e99c65f
Compare
5920f3b to
dbaf8a1
Compare
e99c65f to
6aea7ea
Compare
0a7ca8d to
d4a742e
Compare
bce83e3 to
38d7488
Compare
d4a742e to
71d920a
Compare
myronmarston
requested changes
May 28, 2026
38d7488 to
65c8468
Compare
71d920a to
2561384
Compare
08fa741 to
66a50ff
Compare
7cd0f7d to
3d879aa
Compare
3d879aa to
01d66b2
Compare
01d66b2 to
4d549ec
Compare
myronmarston
approved these changes
May 30, 2026
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Keep the JSON ingestion indexing extensions separate from the schema-extension wiring so the indexing behavior is easier to review.
What
Risk Assessment
Low to medium - this changes internal indexing value objects to use the existing MemoizableData wrapper so JSON ingestion can attach extension modules, without changing core mapping behavior.
References
bundle exec rspec elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/json_schema_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/json_schema_field_metadata_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/indexing/json_schema_with_metadata_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/factory_spec.rbpassed.script/type_checkpassed.script/lintpassed.Stack
Current PR is marked with
->.