Skip to content

Add JSON ingestion indexing extensions#1204

Open
jwils wants to merge 1 commit into
joshuaw/json-ingestion-helper-namespacefrom
joshuaw/json-ingestion-extension-modules
Open

Add JSON ingestion indexing extensions#1204
jwils wants to merge 1 commit into
joshuaw/json-ingestion-helper-namespacefrom
joshuaw/json-ingestion-extension-modules

Conversation

@jwils
Copy link
Copy Markdown
Collaborator

@jwils jwils commented May 20, 2026

Why

Keep the JSON ingestion indexing extensions separate from the schema-extension wiring so the indexing behavior is easier to review.

What

  • Add JSON ingestion extension modules for indexing field references and field types
  • Make core indexing field references and enum/scalar/union field types extendable via the existing MemoizableData helper, matching the object field type
  • Keep JSON ingestion behavior in extension modules; no wrapper classes

Risk Assessment

Low to medium - this changes internal indexing value objects to use the existing MemoizableData wrapper so JSON ingestion can attach extension modules, without changing core mapping behavior.

References

  • Stacked on Namespace JSON schema helpers under JSON ingestion #1203.
  • bundle exec rspec elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/json_schema_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/json_schema_field_metadata_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/indexing/json_schema_with_metadata_spec.rb elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/factory_spec.rb passed.
  • script/type_check passed.
  • script/lint passed.

Stack

Current PR is marked with ->.

@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from 7bc0045 to 6267113 Compare May 20, 2026 20:03
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch 2 times, most recently from 024c4ef to d8c3c70 Compare May 20, 2026 20:15
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch 2 times, most recently from 040cea2 to e6a4787 Compare May 21, 2026 02:49
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from d8c3c70 to b78686f Compare May 21, 2026 02:49
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from e6a4787 to eb21230 Compare May 21, 2026 13:43
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from b78686f to 0b3844f Compare May 21, 2026 13:43
@jwils jwils marked this pull request as ready for review May 22, 2026 18:23
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from 0b3844f to 65f9a60 Compare May 22, 2026 22:41
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from eb21230 to 2afdcd4 Compare May 22, 2026 22:41
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from 65f9a60 to 6be803f Compare May 24, 2026 13:33
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch 2 times, most recently from b03c1a4 to a3171ef Compare May 24, 2026 14:09
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch 2 times, most recently from 159afa8 to 29e7e8e Compare May 24, 2026 14:24
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch 2 times, most recently from bf0dd3b to 34a576b Compare May 24, 2026 14:51
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch 2 times, most recently from 31d7828 to 87c88c1 Compare May 24, 2026 15:00
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from 34a576b to 5920f3b Compare May 24, 2026 15:00
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from 87c88c1 to e99c65f Compare May 24, 2026 15:36
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from 5920f3b to dbaf8a1 Compare May 24, 2026 15:36
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from e99c65f to 6aea7ea Compare May 24, 2026 18:05
@jwils jwils changed the title Add JSON ingestion schema extension modules Add JSON ingestion indexing wrappers May 27, 2026
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from 0a7ca8d to d4a742e Compare May 27, 2026 16:22
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch 2 times, most recently from bce83e3 to 38d7488 Compare May 27, 2026 18:43
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from d4a742e to 71d920a Compare May 27, 2026 18:43
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from 38d7488 to 65c8468 Compare May 28, 2026 18:35
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from 71d920a to 2561384 Compare May 28, 2026 18:35
@jwils jwils changed the title Add JSON ingestion indexing wrappers Add JSON ingestion indexing extensions May 28, 2026
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch 3 times, most recently from 08fa741 to 66a50ff Compare May 28, 2026 19:13
myronmarston

This comment was marked as resolved.

@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch 3 times, most recently from 7cd0f7d to 3d879aa Compare May 30, 2026 14:38
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from 3d879aa to 01d66b2 Compare May 30, 2026 20:03
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from 01d66b2 to 4d549ec Compare May 30, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants