Skip to content

Namespace JSON schema helpers under JSON ingestion#1203

Open
jwils wants to merge 1 commit into
joshuaw/json-ingestion-extensionfrom
joshuaw/json-ingestion-helper-namespace
Open

Namespace JSON schema helpers under JSON ingestion#1203
jwils wants to merge 1 commit into
joshuaw/json-ingestion-extensionfrom
joshuaw/json-ingestion-helper-namespace

Conversation

@jwils
Copy link
Copy Markdown
Collaborator

@jwils jwils commented May 20, 2026

Why

After the move-only PR preserves rename detection, put the moved helper constants under the ElasticGraph::JSONIngestion namespace.

What

  • Namespace the moved JSON Schema helper classes and RBS signatures
  • Update schema_definition references and tests to use the new qualified constants

Risk Assessment

Medium - namespace-only behavior should be unchanged, but it updates call sites across schema_definition.

References

Stack

Current PR is marked with ->.

@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from 7bc0045 to 6267113 Compare May 20, 2026 20:03
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from 461ba24 to 64ff2af Compare May 20, 2026 20:03
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from 6267113 to 040cea2 Compare May 20, 2026 20:15
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from 040cea2 to e6a4787 Compare May 21, 2026 02:49
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from 64ff2af to 7d4becc Compare May 21, 2026 02:49
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from e6a4787 to eb21230 Compare May 21, 2026 13:43
@jwils jwils marked this pull request as ready for review May 22, 2026 18:23
Comment thread elasticgraph-schema_definition/sig/elastic_graph/schema_definition/results.rbs Outdated
Comment thread elasticgraph-schema_definition/sig/elastic_graph/schema_definition/results.rbs Outdated
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from 7d4becc to e64b589 Compare May 22, 2026 22:41
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch 2 times, most recently from 2afdcd4 to b03c1a4 Compare May 24, 2026 13:33
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from e64b589 to 13a3306 Compare May 24, 2026 13:33
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from b03c1a4 to a3171ef Compare May 24, 2026 14:09
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from 13a3306 to a43c868 Compare May 24, 2026 14:09
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from a3171ef to bf0dd3b Compare May 24, 2026 14:24
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch 2 times, most recently from 8956645 to be6a891 Compare May 24, 2026 14:51
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from bf0dd3b to 34a576b Compare May 24, 2026 14:51
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from be6a891 to c3c9a96 Compare May 24, 2026 15:00
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch 2 times, most recently from 5920f3b to dbaf8a1 Compare May 24, 2026 15:36
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from c3c9a96 to 2417f3e Compare May 24, 2026 23:47
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from dbaf8a1 to 00faf9c Compare May 24, 2026 23:47
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from 2417f3e to f813a1b Compare May 24, 2026 23:50
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from 00faf9c to 09f7be8 Compare May 24, 2026 23:50
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from f813a1b to 8bb23ef Compare May 25, 2026 01:10
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from 09f7be8 to 098236c Compare May 25, 2026 01:10
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from 8bb23ef to 28c38ee Compare May 25, 2026 01:17
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch 2 times, most recently from 823b481 to 831b3f5 Compare May 25, 2026 03:43
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from 28c38ee to 7dded60 Compare May 25, 2026 03:44
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch 2 times, most recently from 0a7ca8d to d4a742e Compare May 27, 2026 16:22
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from 7dded60 to 599fab4 Compare May 27, 2026 16:22
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from d4a742e to 71d920a Compare May 27, 2026 18:43
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from 599fab4 to 8fb3abc Compare May 27, 2026 18:43
@jwils jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from 71d920a to 2561384 Compare May 28, 2026 18:35
@jwils jwils force-pushed the joshuaw/json-ingestion-extension branch from 8fb3abc to 1bc3fca Compare May 28, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants