Skip to content

Instantiate indexing field types through factory#1217

Merged
jwils merged 1 commit into
mainfrom
joshuaw/factory-indexing-field-types
May 28, 2026
Merged

Instantiate indexing field types through factory#1217
jwils merged 1 commit into
mainfrom
joshuaw/factory-indexing-field-types

Conversation

@jwils
Copy link
Copy Markdown
Collaborator

@jwils jwils commented May 28, 2026

Why

The JSON ingestion extension needs to extend indexing field type instances through the schema definition factory instead of wrapping them separately.

What

  • Add factory methods for enum, object, scalar, and union indexing field types.
  • Route core to_indexing_field_type call sites through those factory methods.
  • Update the factory RBS signatures.

Verification

  • bundle exec rspec elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/json_schema_spec.rb
  • script/type_check
  • script/lint
  • script/run_gem_specs elasticgraph-schema_definition was not run to completion because the test datastore was not running at http://localhost:9234.

References #1204 (comment).

@jwils jwils marked this pull request as ready for review May 28, 2026 18:04
@jwils jwils merged commit 203f849 into main May 28, 2026
38 of 40 checks passed
@jwils jwils deleted the joshuaw/factory-indexing-field-types branch May 28, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants