Migrate JSON ingestion specs into gem#1224
Draft
jwils wants to merge 1 commit into
Draft
Conversation
9545bf4 to
eee835d
Compare
cd78e96 to
c34ed76
Compare
eee835d to
c0a2045
Compare
c34ed76 to
d4259d8
Compare
c0a2045 to
c1771af
Compare
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The JSON ingestion gem should own the JSON-schema tests that cover its extracted implementation so the gem can enforce full coverage without a SimpleCov skip.
What
elasticgraph-json_ingestion.elasticgraph-json_ingestion.Verification
script/run_gem_specs elasticgraph-json_ingestionscript/type_check elasticgraph-json_ingestionBUNDLE_GEMFILE=Gemfile bundle exec rspec --format progress spec/integration/elastic_graph/schema_definition/rake_tasks_spec.rb spec/unit/elastic_graph/schema_definition/runtime_metadata/scalar_types_by_name_spec.rbfromelasticgraph-schema_definition/bundle exec standardrb ...on touched specs/supportFull
script/run_gem_specs elasticgraph-schema_definitionwas blocked locally because Docker is not running, so the test datastore could not be booted.Stack
Current PR is marked with
->.