Skip to content

Migrate JSON ingestion specs into gem#1224

Draft
jwils wants to merge 1 commit into
joshuaw/json-ingestion-docsfrom
joshuaw/json-ingestion-test-migration
Draft

Migrate JSON ingestion specs into gem#1224
jwils wants to merge 1 commit into
joshuaw/json-ingestion-docsfrom
joshuaw/json-ingestion-test-migration

Conversation

@jwils
Copy link
Copy Markdown
Collaborator

@jwils jwils commented May 31, 2026

Why

The JSON ingestion gem should own the JSON-schema tests that cover its extracted implementation so the gem can enforce full coverage without a SimpleCov skip.

What

  • Move JSON schema generation, metadata merge, pruner, and matcher specs into elasticgraph-json_ingestion.
  • Add JSON-ingestion artifact-manager integration coverage for versioned schema artifacts, version-bump enforcement, metadata refresh, and schema evolution diagnostics.
  • Add focused wrapper/scalar specs for the remaining extracted JSON-ingestion paths.
  • Remove the temporary SimpleCov filter for elasticgraph-json_ingestion.

Verification

  • script/run_gem_specs elasticgraph-json_ingestion
  • script/type_check elasticgraph-json_ingestion
  • BUNDLE_GEMFILE=Gemfile bundle exec rspec --format progress spec/integration/elastic_graph/schema_definition/rake_tasks_spec.rb spec/unit/elastic_graph/schema_definition/runtime_metadata/scalar_types_by_name_spec.rb from elasticgraph-schema_definition/
  • bundle exec standardrb ... on touched specs/support

Full script/run_gem_specs elasticgraph-schema_definition was blocked locally because Docker is not running, so the test datastore could not be booted.

Stack

Current PR is marked with ->.

@jwils jwils force-pushed the joshuaw/json-ingestion-test-migration branch from 9545bf4 to eee835d Compare May 31, 2026 21:14
@jwils jwils force-pushed the joshuaw/json-ingestion-docs branch from cd78e96 to c34ed76 Compare May 31, 2026 21:45
@jwils jwils force-pushed the joshuaw/json-ingestion-test-migration branch from eee835d to c0a2045 Compare May 31, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant