[x3d] mv to builtin subdir for consistency - #23138
Merged
Merged
Conversation
will help with copyright licensing for Debian better split externals from internals of ROOT could be replaced later on with something more crossplatform better divide C from C++ code could become standalone library and link it from ROOT, so better modularization for Debian helps with Doxygen no need for extra exclude path
ferdymercury
added
the
skip code analysis
Test Results 23 files 23 suites 3d 13h 2m 14s ⏱️ For more details on these failures, see this check. Results for commit a04cfc0. ♻️ This comment has been updated with latest results. |
ferdymercury
marked this pull request as ready for review
August 24, 2026 15:39
ferdymercury
requested review from
bellenot,
couet,
dpiparo and
linev
as code owners
August 24, 2026 15:39
linev
requested changes
Aug 25, 2026
linev
left a comment
linev
left a comment
Member
There was a problem hiding this comment.
One can move x3d.h and x3d.c to builtins directory, but we should not split cmake file for ROOT libX3d.so library.
No any library is generated for x3d.c, therefore one can just source it from new location.
as suggested by linev
pcanal
reviewed
Aug 25, 2026
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as already done with glad, mathtext, etc.
will help with copyright licensing auditing for Debian
better split externals from internals of ROOT
could be replaced later on with something more crossplatform better divide C from C++ code
could become standalone library and link it from ROOT, so better modularization for Debian
helps with Doxygen no need for extra exclude path
original author more visibly recognized