Skip to content

[x3d] mv to builtin subdir for consistency #23138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linev merged 5 commits into from
Aug 25, 2026
+7 −3
Merged

[x3d] mv to builtin subdir for consistency #23138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a6f5b8c
[x3d] mv to builtin subdir for consistency
ferdymercury Aug 24, 2026
4072284
Update CMakeLists.txt
ferdymercury Aug 24, 2026
ca92ac3
Update CMakeLists.txt
ferdymercury Aug 24, 2026
90f465e
[cmake] do not split CMakeLists for X3d
ferdymercury Aug 25, 2026
a04cfc0
[cmake] restore comments
ferdymercury Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 graf3d/x3d/src/x3d.c → builtins/x3d/x3d.c
View file
Open in desktop
File renamed without changes.
0 graf3d/x3d/src/x3d.h → builtins/x3d/x3d.h
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion documentation/doxygen/Doxyfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,7 +1087,6 @@ EXCLUDE = ../../interpreter/ \
../../core/newdelete/ \
../../core/textinput/ \
../../builtins/ \
../../graf3d/x3d/ \
../../documentation/doxygen/html

# The EXCLUDE_SYMLINKS tag can be used to select whether or not files or
Expand Down
9 changes: 7 additions & 2 deletions graf3d/x3d/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,19 @@ ROOT_STANDARD_LIBRARY_PACKAGE(X3d
TViewerX3D.h
TX3DFrame.h
SOURCES
src/x3d.c
src/TViewerX3D.cxx
src/TX3DFrame.cxx
../../builtins/x3d/x3d.c
LIBRARIES
${X11_LIBRARIES}
DEPENDENCIES
Graf3d
Gui
)

target_include_directories(X3d PRIVATE ${X11_INCLUDE_DIR})
# This ROOT package depends on a hard-coded builtin C library (x3d) that was forked in 1993 and slightly adapted for ROOT. See
# https://github.com/root-project/root/blob/852600061bcacd9b255d44f6312c96b6b1e00a2d/x3d/inc/x3d.h
# https://github.com/root-project/root/blob/852600061bcacd9b255d44f6312c96b6b1e00a2d/x3d/src/x3d.c
# vs http://hpux.connect.org.uk/hppd/hpux/X11/Viewers/x3d-2.2/ download source and rename from .tar.gz to just .tar

target_include_directories(X3d PRIVATE ${X11_INCLUDE_DIR} src/ ../../builtins/x3d/) # src for src/X3DDefs.h, ../../builtins/x3d/ for x3d.h
Comment thread
pcanal marked this conversation as resolved.
Loading