[x3d] make the C library a static private standalone builtin independent of ROOT - #23151
Merged
Conversation
ferdymercury
added
clean build
Test Results 23 files 23 suites 3d 13h 22m 17s ⏱️ For more details on these failures, see this check. Results for commit 36d4eec. ♻️ This comment has been updated with latest results. |
Member
|
Maybe name for library |
ferdymercury
commented
Aug 26, 2026
as suggested by linev Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
ferdymercury
changed the title
ferdymercury
marked this pull request as ready for review
August 26, 2026 11:43
ferdymercury
requested review from
bellenot,
couet,
dpiparo and
linev
as code owners
August 26, 2026 11:43
dpiparo
approved these changes
Aug 26, 2026
pcanal
reviewed
Aug 26, 2026
pcanal
approved these changes
Aug 26, 2026
pcanal
left a comment
pcanal
left a comment
Member
There was a problem hiding this comment.
LGTM (beside the minor issue of the library name)
ferdymercury
commented
Aug 26, 2026
to prevent ambiguity in case insensitive file systems if we later rename X3d to ROOTX3D as suggested by pcanal Co-authored-by: Philippe Canal <pcanal@fnal.gov> Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
Collaborator
Author
|
Good point, renaming applied. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Addresses intertwining concerns raised in #23138 (comment)
In my opinion, if x3d is going to be removed soon, this extra PR is not needed, intertwining will disappear by itself, and having things in builtins is better towards Debian porting even if a bit wired during the temporary deprecation/removal phase.
If it's not going to be removed, this helps, since Debian packagers might think of packaging this variant of x3d separately rather than having a single monolithic ROOT build system.
Checklist: