Create new notifications for real-time changes

[JacobKH123]

No description provided.

[linear]

MONO-877 Create new notifications for realtime changes

[JacobKH123]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Add notification recipient page #3109
• Add notification tab in event dashboard page #3084
• Create new notifications for real-time changes #3031 👈 (View in Graphite)
• Add SearchableSelectInput and refactor notification types and utils #3069
• Add notification dashboard page #3018
• Add notification dropdown #2979
• Create backend for notifications #2957
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Arguments are passed in the wrong order to notificationService.create(). The URL is being passed as actorGroupId (6th parameter), "URL" as payloadType (7th parameter), and the payload (8th parameter) is missing entirely.

The method signature is:

create(handle, recipientIds, notificationType, title, shortDescription, actorGroupId, payloadType, payload)

This should be:

await notificationService.create(
  handle,
  notificationRecipientIds,
  "NEW_FEEDBACK_FORM",
  "Nytt tilbakemeldingsskjema tilgjengelig",
  `Tilbakemeldingsskjema for ${event.title} er nå tilgjengelig. Gi din tilbakemelding før ${formattedDeadline}.`,
  null,  // actorGroupId
  "URL",  // payloadType
  `${configuration.WEB_PUBLIC_ORIGIN}/tilbakemelding/${event.id}`  // payload
)

This will cause the notification link to be stored incorrectly and users won't be able to navigate to the feedback form.

Suggested change

	await notificationService.create(
	handle,
	notificationRecipientIds,
	"NEW_FEEDBACK_FORM",
	"Nytt tilbakemeldingsskjema tilgjengelig",
	`Tilbakemeldingsskjema for ${event.title} er nå tilgjengelig. Gi din tilbakemelding før ${formattedDeadline}.`,
	`${configuration.WEB_PUBLIC_ORIGIN}/tilbakemelding/${event.id}`,
	"URL"
	)
	await notificationService.create(
	handle,
	notificationRecipientIds,
	"NEW_FEEDBACK_FORM",
	"Nytt tilbakemeldingsskjema tilgjengelig",
	`Tilbakemeldingsskjema for ${event.title} er nå tilgjengelig. Gi din tilbakemelding før ${formattedDeadline}.`,
	null,
	"URL",
	`${configuration.WEB_PUBLIC_ORIGIN}/tilbakemelding/${event.id}`
	)

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.