Add notification dropdown#2979
Draft
Terbau wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
d6e23e1 to
6c25f83
Compare
faba847 to
6d8159e
Compare
6c25f83 to
04e80f7
Compare
6d8159e to
20b39af
Compare
04e80f7 to
d21d581
Compare
20b39af to
f0f08f5
Compare
f0f08f5 to
e82fa2b
Compare
d21d581 to
0cd8e9e
Compare
0cd8e9e to
ec90836
Compare
e82fa2b to
30f3d17
Compare
30f3d17 to
ccd9c46
Compare
ec90836 to
8907be3
Compare
ccd9c46 to
9884c96
Compare
8907be3 to
6d29f53
Compare
9884c96 to
f64d51d
Compare
797836d to
e8b9360
Compare
5ca79ae to
74ec7de
Compare
| {!isRead && <div className={cn("h-2 w-2 rounded-full mx-auto mt-2", unreadDotColor)} />} | ||
| </div> | ||
| <div className="flex flex-col p-0.5 w-full relative"> | ||
| <p className="text-black/70 dark:text-white/70 text-xs ml-auto absolute top-0 right-0">5 timer siden</p> |
There was a problem hiding this comment.
Hardcoded timestamp string will display "5 timer siden" for all notifications regardless of their actual creation time. This should calculate the relative time from notification.createdAt or notification.updatedAt.
// Fix: Replace with dynamic time calculation
<p className="text-black/70 dark:text-white/70 text-xs ml-auto absolute top-0 right-0">
{formatRelativeTime(notification.createdAt)}
</p>
Suggested change
| <p className="text-black/70 dark:text-white/70 text-xs ml-auto absolute top-0 right-0">5 timer siden</p> | |
| <p className="text-black/70 dark:text-white/70 text-xs ml-auto absolute top-0 right-0">{formatRelativeTime(notification.createdAt)}</p> | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
74ec7de to
fd5f781
Compare
2a3952e to
974f446
Compare
fd5f781 to
d0c21e6
Compare
974f446 to
cd0baef
Compare
d0c21e6 to
983ceec
Compare
cd0baef to
24a10f4
Compare
983ceec to
51ecf05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.