Create backend for notifications

[ErlendSae]

No description provided.

[linear]

MONO-859 Create notification backend

[ErlendSae]

• Add notification recipient page #3109
• Add notification tab in event dashboard page #3084
• Create new notifications for real-time changes #3031
• Add SearchableSelectInput and refactor notification types and utils #3069
• Add notification dashboard page #3018
• Add notification dropdown #2979
• Create backend for notifications #2957 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Critical bug: recipientIds are extracted from notificationData but never used to create the recipient records. When a notification is created, no recipients will be added to the database, making the notification invisible to users.

Fix:

async create(handle, notificationData) {
  const { recipientIds, ...data } = notificationData
  const notification = await handle.notification.create({ data })
  await this.addRecipients(handle, notification.id, recipientIds)
  return notification
}

Suggested change

	async create(handle, notificationData) {
	const { recipientIds, ...data } = notificationData
	const notification = await handle.notification.create({ data })
	return notification
	},
	async create(handle, notificationData) {
	const { recipientIds, ...data } = notificationData
	const notification = await handle.notification.create({ data })
	await this.addRecipients(handle, notification.id, recipientIds)
	return notification
	},

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.

[graphite-app]

Bug: recipientIds are extracted from notificationData but ignored during update. If the API allows passing recipientIds in updates, they will be silently ignored, causing unexpected behavior.

Either remove recipientIds from the destructuring if updates shouldn't modify recipients, or implement the recipient update logic:

async update(handle, notificationId, notificationData) {
  const { recipientIds, ...data } = notificationData
  const notification = await handle.notification.update({
    where: { id: notificationId },
    data,
  })
  if (recipientIds !== undefined) {
    await this.addRecipients(handle, notification.id, recipientIds)
  }
  return notification
}

Suggested change

	async update(handle, notificationId, notificationData) {
	const { recipientIds, ...data } = notificationData
	const notification = await handle.notification.update({
	where: { id: notificationId },
	data,
	})
	return notification
	},
	async update(handle, notificationId, notificationData) {
	const { recipientIds, ...data } = notificationData
	const notification = await handle.notification.update({
	where: { id: notificationId },
	data,
	})
	if (recipientIds !== undefined) {
	await this.addRecipients(handle, notification.id, recipientIds)
	}
	return notification
	},

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.