AP_BattMonitor: Keep mavlink_charge_state instanced - #34063
Open
Georacer wants to merge 1 commit into
Open
Conversation
Currently the method will report unhealthy in BATTERY_STATUS.charge_state for ALL batteries, if one battery is unhealthy. Fix it to refer to the current instance only.
IamPete1
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently the method will report unhealthy in BATTERY_STATUS.charge_state for ALL batteries, if one battery is unhealthy.
Fix it to refer to the current instance only.
Classification & Testing (check all that apply and add your own)
I did a SITL flight with a Loweheiser generator and 3 battery monitors configured:
Mid-flight, I turned off and on
SIM_EFI_TYPEfrom 2 to 0.Description
Currently the instanced MAVLink message

BATTERY_STATUS.charge_statewill go unhealthy for all backends.This PR makes it so that it responds individually and correctly per-instance.
