fixed wrong cur_geom_feats address in file of bev_pool_cuda.cu and add QuickCumsumMean function in torch#4
Open
ZouJiu1 wants to merge 3 commits into
Open
fixed wrong cur_geom_feats address in file of bev_pool_cuda.cu and add QuickCumsumMean function in torch#4ZouJiu1 wants to merge 3 commits into
ZouJiu1 wants to merge 3 commits into
Conversation
This was referenced Apr 19, 2026
|
Subject: Question about Fisheye3DOD checkpoints Hi, I saw your recent PR on Fisheye3DOD (the bev_pool_cuda.cu fix) — nice work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution
I fix a problem with wrong cur_geom_feats address in file of bev_pool_cuda.cu.
I also add a new function QuickCumsumMean with pytorch implement.
Problem
The result is different between the output of function QuickCumsumCuda and the output of function QuickCumsum in file bev_pool.py.
The result is also different between the output of function QuickCumsumMeanCuda and the output of function QuickCumsumMean in file bev_pool.py.
the reason is the wrong implement of file bev_pool_cuda.cu
Reproduce
To reproduce the wrong different result, you can follow the instruction of file README.md https://github.com/ZouJiu1/bevPool/blob/master/README.md
step 1
reproduce the problem
download the file bev_pool_cuda.cu
by checking or debuging or printing the variables like error, errorMean, www, tmp, tmp2 in file bev_pool.py, you can reproduce the problem
step 2
fix the problem
by checking variables in file bev_pool.py, you will find the problem is fixed.
Environment:
Ubuntu22.04
Python 3.10.12
torch 2.2.2+cu118
torchvision 0.17.2+cu118
mmcv 2.1.0
mmengine 0.10.7
mmdet 3.3.0
mmdet3d 1.4.0
cuda 11.8
cudnn 8.9.7
gcc g++ 11.4.0
others:
hustvl/MapTR#212
autowarefoundation/autoware_universe#12491
open-mmlab/mmdetection3d#3143
#4
hustvl/VMA#21