-
Notifications
You must be signed in to change notification settings - Fork 169
feat(check): redefine --no-lint for type-check-only workflow #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fengmk2
merged 6 commits into
voidzero-dev:main
from
jong-kyung:feat/check-no-lint-typecheck
Apr 23, 2026
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1a03ca7
feat(check): add TypeCheckOnly variant and from_flags helper
jong-kyung da0c144
feat(check): redefine --no-lint to forward --type-check-only when typ…
jong-kyung 01394d7
test(check): add snap fixtures covering --no-lint type-check-only matrix
jong-kyung 0030c91
docs(check): document --no-fmt/--no-lint flags and type-check-only us…
jong-kyung 3ba2f78
docs(check): drop --type-check-only implementation detail from user g…
jong-kyung 8f3df59
Merge branch 'main' into feat/check-no-lint-typecheck
jong-kyung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| [1]> vp check --no-fmt --no-lint | ||
| error: No checks enabled | ||
|
|
||
| `vp check` did not run because both `--no-fmt` and `--no-lint` were set | ||
| Enable `lint.options.typeCheck` in vite.config.ts to use `vp check --no-fmt --no-lint` for type-check only, or drop a flag to re-enable fmt/lint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/cli/snap-tests/check-fix-no-fmt-no-lint-typecheck/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "name": "check-fix-no-fmt-no-lint-typecheck", | ||
| "version": "0.0.0", | ||
| "private": true | ||
| } |
2 changes: 2 additions & 0 deletions
2
packages/cli/snap-tests/check-fix-no-fmt-no-lint-typecheck/snap.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| > vp check --fix --no-fmt --no-lint | ||
| pass: Found no type errors in 2 files (<variable>ms, <variable> threads) |
2 changes: 2 additions & 0 deletions
2
packages/cli/snap-tests/check-fix-no-fmt-no-lint-typecheck/src/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| const value: number = 42; | ||
| export { value }; |
6 changes: 6 additions & 0 deletions
6
packages/cli/snap-tests/check-fix-no-fmt-no-lint-typecheck/steps.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "env": { | ||
| "VITE_DISABLE_AUTO_INSTALL": "1" | ||
| }, | ||
| "commands": ["vp check --fix --no-fmt --no-lint"] | ||
| } |
8 changes: 8 additions & 0 deletions
8
packages/cli/snap-tests/check-fix-no-fmt-no-lint-typecheck/vite.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| export default { | ||
| lint: { | ||
| options: { | ||
| typeAware: true, | ||
| typeCheck: true, | ||
| }, | ||
| }, | ||
| }; |
5 changes: 5 additions & 0 deletions
5
packages/cli/snap-tests/check-fix-no-lint-typecheck-fail/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "name": "check-fix-no-lint-typecheck-fail", | ||
| "version": "0.0.0", | ||
| "private": true | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.