feat(check): redefine --no-lint for type-check-only workflow#1444
Open
jong-kyung wants to merge 6 commits intovoidzero-dev:mainfrom
Open
feat(check): redefine --no-lint for type-check-only workflow#1444jong-kyung wants to merge 6 commits intovoidzero-dev:mainfrom
jong-kyung wants to merge 6 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jong-kyung
requested review from
cpojer and
fengmk2
and removed request for
cpojer
camc314
reviewed
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redefines
vp check --no-lintso it runs Oxlint's--type-check-onlypath whenlint.options.typeCheckis enabled invite.config.ts, and makesvp check --no-fmt --no-lintthe natural type-check-only invocation.Replaces the abandoned PR #1417 approach (sidecar
.mjs+--no-type-checkCLI flag), which conflicts with upstream PR #1378 handing config resolution
back to oxlint/oxfmt.
Related: closes #1275 for the lint-rule-noise-free type-error triage workflow.
Behavior matrix
vp check --no-lint(typeCheck=true)--type-check-only; lint rules suppressedvp check --no-lint(typeCheck=false/missing)vp check --no-fmt --no-lint(typeCheck=true)vp check --no-fmt --no-lint(typeCheck=false)error: No checks enabledwith remediation hintvp check --fix --no-lint(typeCheck=true)--fix+ read-only type-check diagnostics--no-type-checkCLI flag is not introduced — deferred to a follow-up onceoxlint exposes a symmetric OFF-direction flag for type-check.
Key design notes
lint.options.typeAwareandlint.options.typeCheckare true, matching the--type-check/--type-awareflag dependency inrfcs/check-command.md("If
--no-type-awareis set,--type-checkis also implicitly disabled").--fix --no-linton a typeCheck-enabled project runs fmt--fixandthen type-check as read-only diagnostics. On type error, fmt's completion
pass line is still surfaced so lint-staged / pre-commit flows can tell the
working tree was mutated before the failure (previously swallowed).