fix(aider,openhands): close client on exit + OpenHands Docker MCP docs#2417
Merged
Conversation
From real-app integration testing: - aider: close the Hindsight client when the wrapper owns it, so aiohttp no longer prints 'Unclosed connector' warnings after aider exits. Test-injected clients are left to the caller. Bump 0.1.1. - openhands: document that the OpenHands Docker app loads MCP from UI settings (not the project config.toml), and that the server must be added as a Streamable HTTP server (not SSE) reachable via host.docker.internal. Same hint printed by 'init'. Bump 0.1.1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
9eef9d3 to
9cf0a80
Compare
Member
|
The two red checks here aren't from this PR — they're pre-existing breakage on
Both currently block every open PR. Worth a tiny standalone fix PR against |
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish from the real-app integration test sweep (separate from the Devin Desktop rename + Continue fix in #2410).
aider — close the client on exit
The wrapper opened a Hindsight client (aiohttp session) and never closed it, so
aiderprintedUnclosed connectorwarnings on exit. Nowrun()closes the client when it owns it (a test/caller-injected client is left alone). Regression tests cover both paths. Bumphindsight-aider→ 0.1.1.openhands — document the Docker-app MCP path
Real testing showed the OpenHands Docker app ignores the project
config.tomlourinitwrites — it only loads MCP from UI settings — and adding the server as SSE silently fails (Hindsight's endpoint is Streamable HTTP). Added:host.docker.internal, andinit.Bump
hindsight-openhands→ 0.1.1.Verification
Not included here (tracked separately)
recallwhen explicitly nudged (29 tools + a soft rule). This is a design decision (stronger instruction vs. trimmed toolset) and deserves its own discussion/PR.devin-desktopdir doesn't exist onmainyet).🤖 Generated with Claude Code