fix(ci): unblock main — ruff format drift + CLI refresh_cron field#2427
Open
benfrank241 wants to merge 1 commit into
Open
fix(ci): unblock main — ruff format drift + CLI refresh_cron field#2427benfrank241 wants to merge 1 commit into
benfrank241 wants to merge 1 commit into
Conversation
Two pre-existing failures on main were blocking every open PR: - verify-generated-files: ruff-format drift in test_chunking.py and test_retain_append_mode.py (trailing whitespace + json.dumps reflow). Fixed by running lint.sh. - test-doc-examples (cli): hindsight-cli/src/commands/mental_model.rs no longer compiled after refresh_cron was added to MentalModelTriggerInput. Set refresh_cron: None in both trigger initializers (create + update).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pre-existing failures on
mainare currently red on every open PR (e.g. #2385, #2417) even though those PRs don't touch the affected files. This unblocks them.1.
verify-generated-files— ruff-format drifthindsight-api-slim/tests/test_chunking.pyandtests/test_retain_append_mode.pywere committed without running the formatter (trailing whitespace +json.dumps([...])that ruff reflows to multi-line). The job runslint.sh, which reformats them → diff → fail. Fixed by running./scripts/hooks/lint.sh.2.
test-doc-examples (cli)— CLI out of sync with the clientrefresh_cronwas added toMentalModelTriggerInput, buthindsight-cli/src/commands/mental_model.rswas never updated, so the CLI no longer compiled (missing field refresh_cron, lines 120 & 198). Setrefresh_cron: Nonein both trigger initializers (create + update), preserving existing behaviour.Verification
lint.shclean; the two test files now match formatter output.cargo checkonhindsight-clipasses (regenerates the client from the spec and compiles).🤖 Generated with Claude Code