This repository was archived by the owner on Sep 16, 2022. It is now read-only.
auto/fix_inline_expansion#710
Merged
Merged
Conversation
aafcd46 to
839820f
Compare
Contributor
Author
|
@kenji-miyake @wep21 |
Contributor
|
mm... I'm sorry I'm not sure. 🥺 |
Contributor
|
こういう問題の適切な追い方が知りたい |
Contributor
|
I'm not sure, but there might be a missing header like this #664. |
Contributor
Author
|
@kmiya |
Contributor
Author
|
there may be some linking error in Eigen |
Contributor
Author
|
@TakaHoribe @tkimura4 but tf2_geometry_msgs has a template and it doesnt print error when building fixed at 3828316 the reason why moving this function to cpp works was that cpp file includes tf2_eigen.h |
839820f to
3828316
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
tf2_eigen.hが定義されていなかったため arc_lane_util.hppにinlineで定義されている関数がruntime時に死ぬため修正
Review Procedure
柏の葉の地図で死なないことの確認

Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks