remove old code, fix sdk version, update action#1421
Conversation
cb1kenobi
left a comment
There was a problem hiding this comment.
I love this PR! Needs a couple of small changes.
What's up with the removal of Ti.UI.iPhone.NavigationGroup.js? Is this a breaking change?
DEPRECATED_VERSION = '3.1.3' |
|
The tests fail on WSL for the same reason the CI checks fail below. For example: Not sure what's causing that. Isn't the Android and iOS stuff mocked? |
|
@cb1kenobi did you had some time to look at this? I can put in the fixed again so the test will succeed |
|
@cb1kenobi I've added the |
ti configselected.sdk check (not used anymore)