Skip to content

remove old code, fix sdk version, update action#1421

Merged
cb1kenobi merged 5 commits into
masterfrom
sdkVersion
Dec 19, 2024
Merged

remove old code, fix sdk version, update action#1421
cb1kenobi merged 5 commits into
masterfrom
sdkVersion

Conversation

@m1ga

@m1ga m1ga commented Oct 1, 2024

Copy link
Copy Markdown
Contributor
  • update github action
  • remove <= Ti 10 if cases
  • remove ti config selected.sdk check (not used anymore)
  • add ti sdk version to the test tiapp.xml file
  • use 12.5.0 in the github action so it will work with the test

@cb1kenobi cb1kenobi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this PR! Needs a couple of small changes.

What's up with the removal of Ti.UI.iPhone.NavigationGroup.js? Is this a breaking change?

Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/publish.yml Outdated
Comment thread test/projects/HarnessTemplate/tiapp.xml Outdated
@m1ga

m1ga commented Oct 5, 2024

Copy link
Copy Markdown
Contributor Author

I love this PR! Needs a couple of small changes.

What's up with the removal of Ti.UI.iPhone.NavigationGroup.js? Is this a breaking change?

DEPRECATED_VERSION = '3.1.3' ...Use Ti.UI.NavigationWindow instead..
Think it has been a long time to keep it around :-)

@cb1kenobi

Copy link
Copy Markdown
Member

The tests fail on WSL for the same reason the CI checks fail below. For example:

alloy compile widgets/wpath/ [ios] compiles without critical error
  Expected { code : 1, killed : false, signal : null, cmd : 'alloy compile /home/chris/projects/titanium/alloy/test/projects/Harness --config platform=ios' } to be falsy.

Not sure what's causing that. Isn't the Android and iOS stuff mocked?

@m1ga

m1ga commented Nov 3, 2024

Copy link
Copy Markdown
Contributor Author

@cb1kenobi did you had some time to look at this? I can put in the fixed again so the test will succeed

@m1ga

m1ga commented Dec 19, 2024

Copy link
Copy Markdown
Contributor Author

@cb1kenobi I've added the sdk-version back to the test tiapp.xml so everything is green and we can get this merged + #1420 (and #1410 in the future as it is very hand to get the database if you work with models :) ).

@cb1kenobi cb1kenobi merged commit e90d0e0 into master Dec 19, 2024
@m1ga m1ga deleted the sdkVersion branch December 19, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants