fix models length issue#1420
Merged
Merged
Conversation
Contributor
Author
|
@cb1kenobi any idea why the tests are failing? They work fine locally not sure how I can fix that. |
Member
|
That's not a CLI error, it's an Alloy error: Line 47 in be399c8 Alloy is reading the config to get the selected SDK, but that's obsolete in CLI v7. Alloy should get the SDK version from the |
Contributor
Author
|
ohhhh ok, I didn't check for the error message in the project 🤦 Let me fix that! Thanks for the hint |
Contributor
Author
|
merge #1421 first. There I'm fixing build issues and some other Alloy code |
cb1kenobi
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit difficult to test but in my case I had
which produced:
and models was
nullfor me which caused an error "length of undefined".Instead of crashing it should just use
len = 0for this.merge #1421 first. There I'm fixing build issues and some other Alloy code