Skip to content

Fix protobuf compilation error and CI error #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
benhxy wants to merge 3 commits into
base: master
Choose a base branch
from
+7 −15
Draft

Fix protobuf compilation error and CI error #2171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f78c81
Fix protobuf compilation error
benhxy May 21, 2026
3ed5509
Do not uninstall pip as it's a part of ubuntu 24
benhxy May 21, 2026
84cfbb7
Use preinstalled black and pyupgrade binary
benhxy May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/reviewdog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- run: |
sudo python3 -m pip install -U numpy pip black pyupgrade
sudo python3 -m pip install -U numpy black pyupgrade
bazel run -s --verbose_failures --experimental_repo_remote_exec //tools/lint:lint -- bazel
- uses: reviewdog/action-suggester@a3026c6020837c23b61a79d12db223a00df19e6a # v1.19.0
black:
Expand All @@ -30,7 +30,7 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- run: |
sudo python3 -m pip install -U numpy pip black pyupgrade
sudo python3 -m pip install -U numpy black pyupgrade
bazel run -s --verbose_failures --experimental_repo_remote_exec //tools/lint:lint -- black
- uses: reviewdog/action-suggester@a3026c6020837c23b61a79d12db223a00df19e6a # v1.19.0
clang:
Expand All @@ -42,7 +42,7 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- run: |
sudo python3 -m pip install -U numpy pip black pyupgrade
sudo python3 -m pip install -U numpy black pyupgrade
bazel run -s --verbose_failures --experimental_repo_remote_exec //tools/lint:lint -- clang
- uses: reviewdog/action-suggester@a3026c6020837c23b61a79d12db223a00df19e6a # v1.19.0
pyupgrade:
Expand All @@ -54,6 +54,6 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- run: |
sudo python3 -m pip install -U numpy pip black pyupgrade
sudo python3 -m pip install -U numpy black pyupgrade
bazel run -s --verbose_failures --experimental_repo_remote_exec //tools/lint:lint -- pyupgrade
- uses: reviewdog/action-suggester@a3026c6020837c23b61a79d12db223a00df19e6a # v1.19.0
4 changes: 1 addition & 3 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,7 @@ http_archive(
name = "com_google_googleapis",
build_file = "@com_github_googleapis_google_cloud_cpp//bazel:googleapis.BUILD",
patch_cmds = [
"""sed -i.bak 's/OPTIONAL/OPIONAL/g' google/api/field_behavior.proto""",
"""sed -i.bak 's/OPTIONAL/OPIONAL/g' google/pubsub/v1beta2/pubsub.proto""",
"""sed -i.bak 's/OPTIONAL/OPIONAL/g' google/pubsub/v1/pubsub.proto""",
"""find google/ -name "*.proto" -exec sed -i.bak 's/\\bOPTIONAL\\b/OPIONAL/g' {} +""",
],
sha256 = "249d83abc5d50bf372c35c49d77f900bff022b2c21eb73aa8da1458b6ac401fc",
strip_prefix = "googleapis-6b3fdcea8bc5398be4e7e9930c693f0ea09316a0",
Expand Down
10 changes: 2 additions & 8 deletions tools/lint/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,8 @@ genrule(
name = "pyupgrade",
srcs = [],
outs = ["pyupgrade"],
cmd = "echo '$(location :pyupgrade_py) \"$$@\"' > $@",
cmd = "echo 'pyupgrade \"$$@\"' > $@",
executable = True,
tools = [
":pyupgrade_py",
],
)

py_binary(
Expand All @@ -45,11 +42,8 @@ genrule(
name = "black",
srcs = [],
outs = ["black"],
cmd = "echo '$(location :black_py) \"$$@\"' > $@",
cmd = "echo 'black \"$$@\"' > $@",
executable = True,
tools = [
":black_py",
],
)

genrule(
Expand Down
Loading