Fix protobuf compilation error and CI error#2171
Draft
benhxy wants to merge 3 commits into
Draft
Conversation
benhxy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix protobuf compilation error
The build error was caused by a conflict between a workaround for Windows compilation and the
googleapisdependency. To prevent compilation failures on Windows (whereOPTIONALcan be defined as an empty string by the preprocessor), tensorflow_io had a patch in WORKSPACE that renamedOPTIONALtoOPIONALin google/api/field_behavior.proto and a couple of other proto files in thecom_google_googleapisrepository.However, #2168 brought in google/cloud/bigquery/storage/v1/table.proto which also uses
OPTIONAL. Since the rename patch was only applied to a few hardcoded files, table.proto still usedOPTIONALbut field_behavior.proto define it asOPIONAL, leading to the compilation error:Enum type "google.api.FieldBehavior" has no value named "OPTIONAL" for option "google.api.field_behavior".
Fix CI build error
The error occurred because the workflow was running on
ubuntu-24.04using Python, and attempting to upgradepipitself viasudo python3 -m pip install -U ... pip ....On Ubuntu/Debian, the system-installed pip is managed by apt and does not contain the
RECORDfile that pip expects when uninstalling/upgrading. This caused pip to fail with:ERROR: Cannot uninstall pip 24.0, RECORD file not found. Hint: The package was installed by debian.