Skip to content

Refactor discharge coefficient case statements #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ponceta merged 11 commits into from
Nov 12, 2025
Merged

Refactor discharge coefficient case statements #820

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
56f93de
Refactor discharge coefficient case statements
tproduit Nov 11, 2025
7c640f4
Replace NULL with 0.0 for depth and area fields
tproduit Nov 11, 2025
22b4fa0
Set default values for Geom2 and Culvert to 0
tproduit Nov 11, 2025
16dfd99
Change outfall Type and StageData logic in SQL view
tproduit Nov 11, 2025
cab562d
Enhance view with detailed comments on raingage fields
tproduit Nov 11, 2025
60417dc
Enhance comment for Source field in raingages view
tproduit Nov 11, 2025
7271b50
Update 09_vw_swmm_subcatchments.sql
tproduit Nov 11, 2025
f09ea20
Update 09_vw_swmm_subcatchments.sql
tproduit Nov 11, 2025
1b3015c
Update 08_vw_swmm_outfalls.sql
tproduit Nov 11, 2025
ccdacf5
Update 08_vw_swmm_outfalls.sql
tproduit Nov 11, 2025
93c2af6
Update 08_vw_swmm_outfalls.sql
tproduit Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions datamodel/app/view/swmm_views/09_vw_swmm_subcatchments.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ SELECT
ELSE (ca.surface_area::numeric)::double precision
END AS Area,
CASE
WHEN state = 'rw_current' then discharge_coefficient_rw_current
WHEN state = 'rw_planned' then discharge_coefficient_rw_planned
WHEN state = 'ww_current' then discharge_coefficient_ww_current
WHEN state = 'ww_planned' then discharge_coefficient_ww_planned
WHEN state = 'rw_current' AND discharge_coefficient_rw_current IS NOT NULL then discharge_coefficient_rw_current
WHEN state = 'rw_planned' AND discharge_coefficient_rw_planned IS NOT NULL then discharge_coefficient_rw_planned
WHEN state = 'ww_current' AND discharge_coefficient_ww_current IS NOT NULL then discharge_coefficient_ww_current
WHEN state = 'ww_planned' AND discharge_coefficient_ww_planned IS NOT NULL then discharge_coefficient_ww_planned
ELSE 0
END as percImperv, -- take from catchment_area instead of default value
CASE
Expand Down