Refactor discharge coefficient case statements#820
Merged
Conversation
Updated discharge coefficient cases to check for NULL values before assignment.
Contributor
|
@tproduit I found this old pull request on QGEP that seems to also touch the subject of missing / NULL values: QGEP/datamodel#232 Maybe you could also integrate this here. |
ponceta
approved these changes
Nov 11, 2025
Changed default values from NULL to 0 for Geom2 and Culvert. From https://github.com/QGEP/datamodel/pull/232/commits
Updated the view to include detailed comments for each column, explaining the format, interval, SCF, and source of the rainfall data. From https://github.com/QGEP/datamodel/pull/232/commits
Updated the comment for the Source field to include additional information from SWMM Documentation. https://github.com/QGEP/datamodel/pull/232/commits
Contributor
Should be IS NOT NULL |
Typo from QGEP commit
waterlevel_hydraulic is not available for infiltration installation
Contributor
Author
|
@sjib can you double check the modifications? I was not able to solve the pre-commit issues. It might be a right issue since the fork is hosted by the organisation |
Contributor
|
I installed the Demodata Arbon with TMMT on this pull request branch and was able to create an inp. @TriformMoritz Please have a look. The vw_outfalls seems ok with the adaptions from qgep. 
|
ponceta
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated discharge coefficient cases to check for NULL values before assignment.
To solve issue: #803