Skip to content

platform: RegisterOIDCClient takes a slice of redirect URIs #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cyberb merged 1 commit into from
Jun 6, 2026
Merged

platform: RegisterOIDCClient takes a slice of redirect URIs #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions platform/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,14 @@ func (c *Client) GetAuthLocalSocket() string {
return "http://unix:/var/snap/platform/current/authelia.socket:"
}

func (c *Client) RegisterOIDCClient(id, redirectUri string, requirePkce bool, tokenEndpointAuthMethod string) (string, error) {
func (c *Client) RegisterOIDCClient(id string, redirectUris []string, requirePkce bool, tokenEndpointAuthMethod string) (string, error) {
requirePkceString := "false"
if requirePkce {
requirePkceString = "true"
}
values := url.Values{
"id": {id},
"redirect_uri": {redirectUri},
"redirect_uri": redirectUris,
"require_pkce": {requirePkceString},
"token_endpoint_auth_method": {tokenEndpointAuthMethod},
}
Expand Down
14 changes: 14 additions & 0 deletions platform/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,20 @@ func TestRealHttpClient_Post(t *testing.T) {

}

func TestClient_RegisterOIDCClient_SendsMultipleRedirectUris(t *testing.T) {
httpClient := &HttpClientStub{}
client := &Client{
client: httpClient,
logger: log.Logger(),
}
_, err := client.RegisterOIDCClient("app", []string{"/cb", "/mobile"}, true, "client_secret_basic")
assert.NoError(t, err)
assert.Equal(t, "app", httpClient.values.Get("id"))
assert.Equal(t, []string{"/cb", "/mobile"}, httpClient.values["redirect_uri"])
assert.Equal(t, "true", httpClient.values.Get("require_pkce"))
assert.Equal(t, "client_secret_basic", httpClient.values.Get("token_endpoint_auth_method"))
}

func TestClient_GetAppStorageDir(t *testing.T) {
httpClient := &HttpClientStub{}
client := &Client{
Expand Down