platform: RegisterOIDCClient takes a slice of redirect URIs#1
Merged
Conversation
Replace the single redirectUri string with redirectUris []string so an app can register more than one redirect URI (e.g. a web callback plus a mobile-app callback). url.Values encodes the slice as repeated redirect_uri fields, which the platform reads via req.Form["redirect_uri"]. Breaking change: callers must pass []string. The platform side already accepts one or many values, so a single-element slice behaves exactly as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the single
redirectUri stringwithredirectUris []stringso an app can register more than one redirect URI per OIDC client (e.g. a web callback and a mobile-app callback).url.Valuesencodes the slice as repeatedredirect_urifields:which the platform reads via
req.Form["redirect_uri"](see syncloud/platform#749).Breaking change: callers must pass
[]string. Since the platform accepts one or many values, a single-element slice behaves exactly as before — consuming apps update the call when they next bump golib.Added
TestClient_RegisterOIDCClient_SendsMultipleRedirectUrisasserting both URIs are sent.