Skip to content

Revert "fix(es/minifier): respect ecma for iife temp vars (#11873)"#11878

Merged
kdy1 merged 2 commits into
swc-project:mainfrom
hardfist:revert-11873-fix/minifier-ecma5-iife-temp-var
May 21, 2026
Merged

Revert "fix(es/minifier): respect ecma for iife temp vars (#11873)"#11878
kdy1 merged 2 commits into
swc-project:mainfrom
hardfist:revert-11873-fix/minifier-ecma5-iife-temp-var

Conversation

@hardfist
Copy link
Copy Markdown
Collaborator

@hardfist hardfist commented May 21, 2026

This reverts commit e481934.
#11873 may break #8246 again

Description:

BREAKING CHANGE:

Related issue (if exists):

@hardfist hardfist requested review from a team as code owners May 21, 2026 13:28
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5baddb14d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/swc_ecma_minifier/src/compress/optimize/iife.rs
kdy1
kdy1 previously approved these changes May 21, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 21, 2026

Merging this PR will not alter performance

✅ 219 untouched benchmarks
⏩ 31 skipped benchmarks1


Comparing hardfist:revert-11873-fix/minifier-ecma5-iife-temp-var (4408e2e) with main (7b57d1f)

Open in CodSpeed

Footnotes

  1. 31 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 21, 2026

🦋 Changeset detected

Latest commit: 4408e2e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 merged commit 3b1a217 into swc-project:main May 21, 2026
66 checks passed
@github-actions github-actions Bot added this to the Planned milestone May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants