Skip to content

Revert "fix(es/minifier): respect ecma for iife temp vars (#11873)" #11878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdy1 merged 2 commits into from
May 21, 2026
Merged

Revert "fix(es/minifier): respect ecma for iife temp vars (#11873)" #11878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5baddb1
Revert "fix(es/minifier): respect ecma for iife temp vars (#11873)"
hardfist May 21, 2026
4408e2e
chore: add changeset for minifier revert
kdy1 May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .changeset/respect-ecma-iife-temp-vars.md
View file
Open in desktop

This file was deleted.

7 changes: 7 additions & 0 deletions .changeset/revert-iife-temp-var-ecma.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
swc: patch
swc_core: patch
swc_ecma_minifier: patch
---

fix(es/minifier): revert ecma-dependent IIFE temp var declarations
2 changes: 1 addition & 1 deletion crates/swc/tests/fixture/issues-5xxx/5865/output/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
var a;v=(a=r,b=>a.map(t=>{if(t)return t.foo}));
let a;v=(a=r,b=>a.map(t=>{if(t)return t.foo}));
8 changes: 4 additions & 4 deletions crates/swc/tests/fixture/issues-8xxx/8246/output/input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
function withLog(t) {
let e = {};
for(let n in t){
var o;
e[n] = (o = n, function() {
return console.log(o + ' invoked'), t[o].apply(this, arguments);
for(let o in t){
let n;
e[o] = (n = o, function() {
return console.log(n + ' invoked'), t[n].apply(this, arguments);
});
}
return e;
Expand Down
6 changes: 1 addition & 5 deletions crates/swc_ecma_minifier/src/compress/optimize/iife.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,11 +686,7 @@ impl Optimizer<'_> {
self.prepend_stmts.push(
VarDecl {
span: DUMMY_SP,
kind: if self.options.ecma >= EsVersion::Es2015 {
VarDeclKind::Let
} else {
VarDeclKind::Var
},
kind: VarDeclKind::Let,
Comment thread
hardfist marked this conversation as resolved.
declare: Default::default(),
decls: vars,
..Default::default()
Expand Down
6 changes: 3 additions & 3 deletions crates/swc_ecma_minifier/tests/benches-full/terser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7449,8 +7449,7 @@
def_eval(AST_BigInt, function() {
return supports_bigint ? BigInt(this.value) : this;
}), def_eval(AST_RegExp, function(compressor) {
var source;
let evaluated = compressor.evaluated_regexps.get(this.value);
let source, evaluated = compressor.evaluated_regexps.get(this.value);
if (void 0 === evaluated && (source = this.value.source, re_safe_regexp.test(source))) {
try {
let { source, flags } = this.value;
Expand Down Expand Up @@ -10109,7 +10108,8 @@
}).optimize(compressor);
break;
case "RegExp":
var source, params = [];
let source;
var params = [];
if (self1.args.length >= 1 && self1.args.length <= 2 && self1.args.every((arg)=>{
var value = arg.evaluate(compressor);
return params.push(value), arg !== value;
Expand Down
5 changes: 0 additions & 5 deletions crates/swc_ecma_minifier/tests/fixture/issues/ecma5-iife-temp-var/config.json
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions crates/swc_ecma_minifier/tests/fixture/issues/ecma5-iife-temp-var/input.js
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions crates/swc_ecma_minifier/tests/fixture/issues/ecma5-iife-temp-var/output.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion crates/swc_ecma_minifier/tests/fixture/issues/react-instancesearch/002/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ let isMultiIndexContext = (widget)=>hasMultipleIndices({
return {
...request,
params: Object.keys(parameters = request.params).map((key)=>{
var value;
let value;
return ((format, ...args)=>{
let i = 0;
return format.replace(/%s/g, ()=>encodeURIComponent(args[i++]));
Expand Down
2 changes: 1 addition & 1 deletion crates/swc_ecma_minifier/tests/fixture/issues/react-instancesearch/003/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ let isMultiIndexContext = (widget)=>hasMultipleIndices({
return {
...request,
params: Object.keys(parameters = request.params).map((key)=>{
var value;
let value;
return ((format, ...args)=>{
let i = 0;
return format.replace(/%s/g, ()=>encodeURIComponent(args[i++]));
Expand Down
3 changes: 2 additions & 1 deletion crates/swc_ecma_minifier/tests/fixture/next/47005/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@
{
/***/ 9145: /***/ function(m, S, h) {
"use strict";
let E, k;
/* harmony export */ h.d(S, {
/* harmony export */ u: function() {
return /* binding */ ei;
}
});
/* unused harmony exports TooltipProvider, TooltipWrapper */ /* harmony import */ var E, k, R, A = h(7294);
/* unused harmony exports TooltipProvider, TooltipWrapper */ /* harmony import */ var R, A = h(7294);
/* harmony import */ var O = h(5893);
var L = Object.create;
var j = Object.defineProperty;
Expand Down
2 changes: 1 addition & 1 deletion crates/swc_ecma_minifier/tests/libs-size.snapshot.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
| lodash.js | 531.35 KiB | 68.92 KiB | 24.60 KiB |
| moment.js | 169.83 KiB | 57.34 KiB | 18.25 KiB |
| react.js | 70.45 KiB | 22.45 KiB | 8.04 KiB |
| terser.js | 1.08 MiB | 446.63 KiB | 120.50 KiB |
| terser.js | 1.08 MiB | 446.63 KiB | 120.49 KiB |
| three.js | 1.19 MiB | 630.55 KiB | 154.77 KiB |
| typescript.js | 10.45 MiB | 3.17 MiB | 840.61 KiB |
| victory.js | 2.30 MiB | 694.04 KiB | 154.18 KiB |
Expand Down
Loading