Skip to content

fix: strip unused link reference definitions in legacy path #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hashim1999164 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: strip unused link reference definitions in legacy path #1066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions dist/showdown.esm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*! showdown v 3.0.0-rc2 - 05-07-2026 */
/*! showdown v 3.0.0-rc2 - 22-07-2026 */
const showdown = (function () {
// noinspection HtmlRequiredLangAttribute

Expand Down Expand Up @@ -12102,12 +12102,9 @@ showdown.subParser('makehtml.stripLinkDefinitions', function (text, options, glo
text += '¨0';

let replaceFunc = function (wholeMatch, linkId, url, width, height, blankLines, title) {

// if there aren't two instances of linkId it must not be a reference link so back out
// Always strip matching definitions; unused defs must produce no output
// (Markdown.pl / CommonMark). Do not require a second occurrence of linkId.
linkId = showdown.helper.caseFold(linkId);
if (showdown.helper.caseFold(text).split(linkId).length - 1 < 2) {
return wholeMatch;
}

let captureStartEvent = new showdown.Event('makehtml.stripLinkDefinitions.onCapture', wholeMatch);
captureStartEvent
Expand Down
4 changes: 2 additions & 2 deletions dist/showdown.esm.min.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/showdown.esm.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 3 additions & 6 deletions dist/showdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
;/*! showdown v 3.0.0-rc2 - 05-07-2026 */
;/*! showdown v 3.0.0-rc2 - 22-07-2026 */
(function(){
// noinspection HtmlRequiredLangAttribute

Expand Down Expand Up @@ -12102,12 +12102,9 @@ showdown.subParser('makehtml.stripLinkDefinitions', function (text, options, glo
text += '¨0';

let replaceFunc = function (wholeMatch, linkId, url, width, height, blankLines, title) {

// if there aren't two instances of linkId it must not be a reference link so back out
// Always strip matching definitions; unused defs must produce no output
// (Markdown.pl / CommonMark). Do not require a second occurrence of linkId.
linkId = showdown.helper.caseFold(linkId);
if (showdown.helper.caseFold(text).split(linkId).length - 1 < 2) {
return wholeMatch;
}

let captureStartEvent = new showdown.Event('makehtml.stripLinkDefinitions.onCapture', wholeMatch);
captureStartEvent
Expand Down
4 changes: 2 additions & 2 deletions dist/showdown.min.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/showdown.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 2 additions & 5 deletions src/subParsers/makehtml/stripLinkDefinitions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,9 @@ showdown.subParser('makehtml.stripLinkDefinitions', function (text, options, glo
text += '¨0';

let replaceFunc = function (wholeMatch, linkId, url, width, height, blankLines, title) {

// if there aren't two instances of linkId it must not be a reference link so back out
// Always strip matching definitions; unused defs must produce no output
// (Markdown.pl / CommonMark). Do not require a second occurrence of linkId.
linkId = showdown.helper.caseFold(linkId);
if (showdown.helper.caseFold(text).split(linkId).length - 1 < 2) {
return wholeMatch;
}

let captureStartEvent = new showdown.Event('makehtml.stripLinkDefinitions.onCapture', wholeMatch);
captureStartEvent
Expand Down
2 changes: 2 additions & 0 deletions test/functional/makehtml/cases/issues/1061.unused-link-definition-leaks.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<p>one</p>
<p>two</p>
7 changes: 7 additions & 0 deletions test/functional/makehtml/cases/issues/1061.unused-link-definition-leaks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
[unused]: http://example.com/

one

[zqx]: /url

two