fix: strip unused link reference definitions in legacy path - #1066
Open
Hashim1999164 wants to merge 1 commit into
Open
fix: strip unused link reference definitions in legacy path#1066Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
Remove the occurrence-count heuristic that left unused [id]: url definitions in the HTML output for non-cmSpec flavors. Fixes showdownjs#1061
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stripLinkDefinitionsrequired the link id to appear at least twice.test/functional/makehtml/cases/issues/.Fixes #1061
Test plan
vitest run test/functional/makehtml/(1966 tests passed)new Converter().makeHtml('[unused]: http://example.com/')returns""[x]: take out the garbagestill preserved as paragraph text