Skip to content

fix: Style loss when taking screenshots #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZhengIce wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Style loss when taking screenshots #426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 10 additions & 26 deletions packages/core/src/modules/screenshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Canvas, defaultStyle } from "../canvas";
import { Canvas } from "../canvas";
import { Context } from "../context";
// import { locale } from "../locale";
import { hasPartMC } from "./validation";
Expand Down Expand Up @@ -69,21 +69,22 @@ export function handleScreenShot(ctx: Context) {
let scrollHeight;
let rh_height;
if (st_r - 1 < 0) {
scrollHeight = 0;
rh_height = ctx.visibledatarow[ed_r];
scrollHeight = -1.5;
rh_height = ctx.visibledatarow[ed_r] + 1.5;
} else {
scrollHeight = ctx.visibledatarow[st_r - 1];
rh_height = ctx.visibledatarow[ed_r] - ctx.visibledatarow[st_r - 1];
scrollHeight = ctx.visibledatarow[st_r - 1] - 1.5;
rh_height = ctx.visibledatarow[ed_r] - ctx.visibledatarow[st_r - 1] + 1.5;
}

let scrollWidth;
let ch_width;
if (st_c - 1 < 0) {
scrollWidth = 0;
ch_width = ctx.visibledatacolumn[ed_c];
scrollWidth = -1.5;
ch_width = ctx.visibledatacolumn[ed_c] + 1.5;
} else {
scrollWidth = ctx.visibledatacolumn[st_c - 1];
ch_width = ctx.visibledatacolumn[ed_c] - ctx.visibledatacolumn[st_c - 1];
scrollWidth = ctx.visibledatacolumn[st_c - 1] - 1.5;
ch_width =
ctx.visibledatacolumn[ed_c] - ctx.visibledatacolumn[st_c - 1] + 1.5;
}
const newCanvasElement = document.createElement("canvas");
newCanvasElement.width = Math.ceil(ch_width * devicePixelRatio);
Expand All @@ -104,23 +105,6 @@ export function handleScreenShot(ctx: Context) {
const ctx_newCanvas = newCanvasElement.getContext("2d");
if (ctx_newCanvas == null) return undefined;

// 补上 左边框和上边框
ctx_newCanvas.beginPath();
ctx_newCanvas.moveTo(0, 0);
ctx_newCanvas.lineTo(0, ctx.devicePixelRatio * rh_height);
ctx_newCanvas.lineWidth = ctx.devicePixelRatio * 2;
ctx_newCanvas.strokeStyle = defaultStyle.strokeStyle;
ctx_newCanvas.stroke();
ctx_newCanvas.closePath();

ctx_newCanvas.beginPath();
ctx_newCanvas.moveTo(0, 0);
ctx_newCanvas.lineTo(ctx.devicePixelRatio * ch_width, 0);
ctx_newCanvas.lineWidth = ctx.devicePixelRatio * 2;
ctx_newCanvas.strokeStyle = defaultStyle.strokeStyle;
ctx_newCanvas.stroke();
ctx_newCanvas.closePath();

const image = new Image();
const url = newCanvasElement.toDataURL("image/png");
image.src = url;
Expand Down