Skip to content

fix: Style loss when taking screenshots - #426

Open
ZhengIce wants to merge 1 commit into
masterfrom
screenShotBorder
Open

fix: Style loss when taking screenshots#426
ZhengIce wants to merge 1 commit into
masterfrom
screenShotBorder

Conversation

@ZhengIce

Copy link
Copy Markdown
Contributor

fix:

  • Incomplete display of border style when taking screenshots

@zyc9012 zyc9012 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wireframes are missing
image

@ZhengIce

Copy link
Copy Markdown
Contributor Author

@zyc9012 By default, there is no border on the edge. What do you mean is that when taking screenshots, the border on the edge should also be added to display it

@zyc9012

zyc9012 commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

@ZhengIce. Top and left border are not rendered for cell area because they are taken by row header bottom line and column header right line. But in screenshot we need to add them back. In case it overrides the manually set borders, you can try to draw it along with other default borders (or wireframe) to see if it affects anything visually.

@ZhengIce

Copy link
Copy Markdown
Contributor Author

Okay, I will study it further.

@zyc9012
zyc9012 force-pushed the master branch 3 times, most recently from 471416d to 829cacb Compare April 5, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants