Skip to content

ValidationErrors initialize check args[:errors] is present #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wuxiaoyi wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ValidationErrors initialize check args[:errors] is present #1259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83e9c45
ValidationErrors initialize check args[:errors] is present
Jan 27, 2016
85ae17a
Add ValidationErrors test, restore error description
Jan 29, 2016
0f720e3
fix fail description
Jan 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/grape/exceptions/validation_errors.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ class ValidationErrors < Grape::Exceptions::Base
attr_reader :errors

def initialize(args = {})
fail 'Params are missing:' unless args.key? :errors
@errors = {}
args[:errors].each do |validation_error|
@errors[validation_error.params] ||= []
Expand Down
4 changes: 4 additions & 0 deletions spec/grape/exceptions/validation_errors_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
it 'should assign headers through base class' do
expect(subject.headers).to eq(headers)
end

it 'fails when params are missing' do
expect { described_class.new(headers: headers) }.to raise_error(RuntimeError, 'Params are missing:')
end
end

context 'message' do
Expand Down