ValidationErrors initialize check args[:errors] is present#1259
Open
wuxiaoyi wants to merge 3 commits into
Open
ValidationErrors initialize check args[:errors] is present#1259wuxiaoyi wants to merge 3 commits into
wuxiaoyi wants to merge 3 commits into
Conversation
Member
|
Thanks! The first change broke a legit spec. I think it already says "Params are missing", so it's confusing to say "Params are missing: params", no? The second one looks legit, but in which context do you get it? At least needs a test. |
Author
|
@dblock , thank you for your review :-) |
Member
|
Re-reading all this I have more questions, sorry :) First, for this implementation. The error should be an Finally, maybe it just makes sense to treat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValidationErrors will throw NoMethodError (undefined method `each' for nil:NilClass) when I manually throw a ValidationErrors exception without params.
This argument appears to be necessary, so it should detect the presence or absence of this key. Or give it a default value.
And the fail word should let us know which key is missing.