Skip to content

Have implicit arguments with "Asymmetric Patterns"#21947

Merged
coqbot-app[bot] merged 2 commits into
rocq-prover:masterfrom
proux01:asymmetric-patterns-no-implicits
May 29, 2026
Merged

Have implicit arguments with "Asymmetric Patterns"#21947
coqbot-app[bot] merged 2 commits into
rocq-prover:masterfrom
proux01:asymmetric-patterns-no-implicits

Conversation

@proux01

@proux01 proux01 commented Apr 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes / closes #21769

To ease the transition to the new behavior, a new flag Asymmetric Patterns No Implicits (off by default) enables to retrieve the previous behavior.

  • Added / updated test-suite.
  • Added changelog.
  • Added / updated documentation.
    • Documented any new / changed user messages.
    • Updated documented syntax by running make doc_gram_rsts.

Overlays (to be merged before the current PR)

All overlays are only setting the new Asymmetric Patterns No Implicits flag wherever Asymmetric Patterns was already set.

@proux01 proux01 added the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 23, 2026
@coqbot-app coqbot-app Bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 23, 2026
@rocq-prover rocq-prover deleted a comment from coqbot-app Bot Apr 23, 2026
proux01 added a commit to rocq-community/coq-ext-lib that referenced this pull request Apr 23, 2026
@proux01
Adapt to rocq-prover/rocq#21947
e0b5c4d
proux01 added a commit to proux01/kami that referenced this pull request Apr 23, 2026
@proux01
Adapt to rocq-prover/rocq#21947
c1716eb
@proux01 proux01 added the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 23, 2026
@coqbot-app coqbot-app Bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 23, 2026
@proux01 proux01 added kind: fix This fixes a bug or incorrect documentation. part: implicit arguments The implicit arguments mechanism, generalizable variables, etc. labels Apr 23, 2026
proux01 added a commit to proux01/HoTT that referenced this pull request Apr 23, 2026
@proux01
Adapt to rocq-prover/rocq#21947
b87737e
proux01 added a commit to rocq-community/coq-ext-lib that referenced this pull request Apr 23, 2026
@proux01
Adapt to rocq-prover/rocq#21947
fb2b65d
proux01 added a commit to proux01/mathcomp that referenced this pull request Apr 23, 2026
@proux01
Adapt to rocq-prover/rocq#21947
5dc2329
@proux01 proux01 added the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 23, 2026
@proux01 proux01 force-pushed the asymmetric-patterns-no-implicits branch from d2251c7 to 071a812 Compare April 23, 2026 13:13
@coqbot-app coqbot-app Bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 23, 2026
@proux01 proux01 added the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 23, 2026
@proux01 proux01 force-pushed the asymmetric-patterns-no-implicits branch from 071a812 to fd3b165 Compare April 23, 2026 13:56
@coqbot-app coqbot-app Bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 23, 2026
This was referenced Apr 23, 2026
Merged
Merged
Merged
Merged
Merged
Merged
proux01 added a commit to proux01/fiat-crypto that referenced this pull request Apr 23, 2026
@proux01
Adapt to rocq-prover/rocq#21947
327c6f9
This was referenced Apr 23, 2026
Merged
Merged
Merged
Merged
Merged
proux01 added a commit to proux01/mathcomp that referenced this pull request Apr 28, 2026
@proux01
Adapt to rocq-prover/rocq#21947
2667303
proux01 added a commit to rocq-community/coq-ext-lib that referenced this pull request Apr 28, 2026
@proux01
Merge pull request #162 from rocq-community/rocq21947
ddd03d2 
Adapt to rocq-prover/rocq#21947
samuelgruetter added a commit to mit-plv/kami that referenced this pull request Apr 28, 2026
@samuelgruetter
Merge pull request #47 from proux01/rocq21947
0438148 
Adapt to rocq-prover/rocq#21947
proux01 added a commit to rocq-prover/stdlib that referenced this pull request Apr 28, 2026
@proux01
Adapt to rocq-prover/rocq#21947
9b897ac
proux01 added a commit to rocq-prover/stdlib that referenced this pull request Apr 28, 2026
@proux01
Merge pull request #259 from proux01/rocq21947
1d2db65 
Adapt to rocq-prover/rocq#21947
damien-pous pushed a commit to damien-pous/relation-algebra that referenced this pull request Apr 28, 2026
@proux01 @damien-pous
Adapt to rocq-prover/rocq#21947
ba18468
proux01 added a commit to proux01/mathcomp that referenced this pull request Apr 30, 2026
@proux01
Adapt to rocq-prover/rocq#21947
82a9b5d
@github-actions github-actions Bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Apr 30, 2026
proux01 added a commit to proux01/mathcomp that referenced this pull request May 3, 2026
@proux01
Adapt to rocq-prover/rocq#21947
a462618
CohenCyril added a commit to math-comp/math-comp that referenced this pull request May 5, 2026
@CohenCyril
Merge pull request #1585 from proux01/rocq21947
d913930 
Adapt to rocq-prover/rocq#21947
damien-pous pushed a commit to damien-pous/aac-tactics that referenced this pull request May 6, 2026
@proux01
Adapt to rocq-prover/rocq#21947
94147eb
andrew-appel pushed a commit to PrincetonUniversity/VST that referenced this pull request May 26, 2026
@proux01
Adapt to rocq-prover/rocq#21947 (#855)
dcb8364
ppedrot pushed a commit to MetaRocq/metarocq that referenced this pull request May 26, 2026
@proux01
Adapt to rocq-prover/rocq#21947
08e4534
ppedrot added a commit to MetaRocq/metarocq that referenced this pull request May 26, 2026
@ppedrot
Merge pull request #1265 from proux01/rocq21947
63d3fa2 
Adapt to rocq-prover/rocq#21947
proux01 added a commit to proux01/Coq-Equations that referenced this pull request May 28, 2026
@proux01
Adapt to rocq-prover/rocq#21947
65f7e8e
proux01 added a commit to proux01/Coq-Equations that referenced this pull request May 28, 2026
@proux01
Adapt to rocq-prover/rocq#21947
bd29b9a
SkySkimmer added a commit to rocq-prover/equations that referenced this pull request May 28, 2026
@SkySkimmer
Merge pull request #714 from proux01/rocq21947
6b360db 
Adapt to rocq-prover/rocq#21947
@proux01 proux01 added the request: full CI Use this label when you want your next push to trigger a full CI. label May 28, 2026
@proux01 proux01 force-pushed the asymmetric-patterns-no-implicits branch from fd3b165 to 945cc13 Compare May 28, 2026 11:33
@coqbot-app coqbot-app Bot removed request: full CI Use this label when you want your next push to trigger a full CI. needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. labels May 28, 2026
proux01 added 2 commits May 28, 2026 13:34
@proux01
Have implicit arguments with "Asymmetric Patterns"
01d2f00 
Add a flag "Asymmetric Patterns No Implicits" (false by default) that
can be set to true to retrieve the previous behavior of "Asymmetric
Patterns" (needed for backward compat).
@proux01
Improve pattern externalization with Asymettric Patterns
0ff5c74
@proux01 proux01 added the request: full CI Use this label when you want your next push to trigger a full CI. label May 28, 2026
@proux01 proux01 force-pushed the asymmetric-patterns-no-implicits branch from 945cc13 to 0ff5c74 Compare May 28, 2026 11:35
@coqbot-app coqbot-app Bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label May 28, 2026
@proux01

proux01 commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

CI green, this one is ready

@SkySkimmer

SkySkimmer commented May 29, 2026

Copy link
Copy Markdown
Contributor

@coqbot merge now

@coqbot-app coqbot-app Bot merged commit 1fc7ef0 into rocq-prover:master May 29, 2026
8 checks passed
@proux01 proux01 deleted the asymmetric-patterns-no-implicits branch May 29, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SkySkimmer SkySkimmer SkySkimmer approved these changes

Assignees

@SkySkimmer SkySkimmer

Labels

kind: fix This fixes a bug or incorrect documentation. part: implicit arguments The implicit arguments mechanism, generalizable variables, etc.

Projects

None yet

Milestone

9.3+rc1

Development

Successfully merging this pull request may close these issues.

Asymmetric Patterns sometimes adds parameters instead of just removing them (doesn't handle implicit arguments correctly)

2 participants

@proux01 @SkySkimmer