Adapt to https://github.com/rocq-prover/rocq/pull/21947#1265
Merged
Conversation
5 tasks
Contributor
Author
|
CI green both here and on upstream PR, please merge |
SkySkimmer
reviewed
May 18, 2026
| From MetaRocq.Utils Require Export MRUtils monad_utils. | ||
|
|
||
| Global Set Asymmetric Patterns. | ||
| #[warning="-unknown-option"] Global Set Asymmetric Patterns No Implicits. |
Contributor
There was a problem hiding this comment.
we really shouldn't use global
Contributor
There was a problem hiding this comment.
this one is fine because Set Asymmetric Patterns above is also global but the others should probably match their Set Asymmetric Patterns
Contributor
|
ping @MetaRocq |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt to rocq-prover/rocq#21947
Should be backward compatible