RI-8268 Translate success & infinite notifications (round 2)#6126
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
Code Coverage - Integration Tests
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f32a2da63b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f32a2da to
e3e6b82
Compare
e63fa65 to
b5ffaae
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5ffaae178
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 403254f8ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
779312a to
62958ea
Compare
403254f to
12f1111
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 12f1111. Configure here.
12f1111 to
1a6659f
Compare
Migrate success-messages.tsx factories to i18n (notification.success.* keys),
using the i18n singleton + <Trans> for bold names, the Release Notes link, and
{{total}} counts. MESSAGE_ACTION now resolves its action word (claimed/
acknowledged) through i18n so the whole toast localizes.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Migrate INFINITE_MESSAGES to i18n (notification.infinite.* keys) via the i18n singleton + <Trans> for the bold Notice and inline Redis Cloud link, with a button.* segment for the action labels (Manage DB, Connect, Import, OK, Create, Restart). Keys re-sorted to i18next-cli's canonical order via i18n:extract. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The value type (Member/Field/Group/Entry/Element/Consumer/JSON key) was an English literal interpolated into the title, producing mixed-language Bulgarian toasts. Add a per-type title key for each so it reads correctly and agrees in gender in Bulgarian. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
<Trans> parses interpolated values as markup (escapeValue is off), so a Redis key/name containing e.g. "<br/>" was rendered as a tag instead of literal text. Escape the user-provided values before interpolating them. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1a6659f to
042c0a2
Compare
Code Coverage - Frontend unit tests
Test suite run success7491 tests passing in 842 suites. Report generated by 🧪jest coverage report action from 042c0a2 |

What
Round 2 of frontend notification translation, stacked on the round-1 error-path PR (#6125). This round localizes the success and infinite (persistent/in-progress) toasts, and aligns the whole notification namespace.
Testing
Manual — drop this dev helper into
App.tsx(after thethemeServicecalls) totrigger every toast from the browser console, then remove it:
Then in the browser console:
Append
?lang=bgto verify Bulgarian. (Infinite toasts are persistent — closethem between triggers, or they stack.)
Before / After
Success notifications
Infinite notifications
Part of RI-8268
Related community requests: #605, #1317, #1883, #2040, #2137, #2181, #2213, #2417, #2550, #2590, #2695, #2715, #2716, #2727, #2828, #2912, #2943, #2945, #3081, #3141, #3142, #3319, #3411, #3601, #3625, #3628, #3663, #3671, #3812, #3815, #4150, #4182, #4408, #4664, #4672, #4744, #5052, #5967
Note
Low Risk
Presentation-only i18n with a small hardening change for Trans interpolation; call sites already use the new MESSAGE_ACTION signature.
Overview
This PR localizes persistent/in-progress and success toasts by replacing hardcoded English in
InfiniteMessages.tsxandsuccess-messages.tsxwithi18n.t/Trans, and adds matchingnotification.infinite.*andnotification.success.*strings inen.jsonandbg.json.Rich copy (bold names, Redis Cloud / Release Notes links, inactivity notice) now uses
Transcomponent slots instead of inline JSX.MESSAGE_ACTIONtakes a message id plus a typedclaimed|acknowledgedaction so the verb can be translated separately.escapeTransescapes user-controlled names/ids before they go into<Trans>markup, reducing accidental HTML injection whenescapeValueis off. Bulk-upload stat labels getwhiteSpace: 'nowrap'for longer translated text.Reviewed by Cursor Bugbot for commit 042c0a2. Bugbot is set up for automated code reviews on this repo. Configure here.