Exhaustive search: precompute assignment-independent constraint data#3781
Open
pacheco wants to merge 3 commits into
Open
Exhaustive search: precompute assignment-independent constraint data#3781pacheco wants to merge 3 commits into
pacheco wants to merge 3 commits into
Conversation
Precompute everything assignment-independent once per exhaustive-search variable set instead of clone + substitute + solve per assignment. Adds GroupedExpression::evaluate_assignment. Output-identical. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precompute everything assignment-independent once per exhaustive-search variable set instead of clone + substitute + solve per assignment.
Adds GroupedExpression::evaluate_assignment. Should be output-identical to calling solve.
On my machine, this improves the wasm reth apc benchmark by ~3.8x