constraint-solver: compute solved-for range constraints directly#3782
Open
pacheco wants to merge 1 commit into
Open
constraint-solver: compute solved-for range constraints directly#3782pacheco wants to merge 1 commit into
pacheco wants to merge 1 commit into
Conversation
Avoid materializing a solved expression per variable via try_solve_for. Instead compute each variable's implied range constraint directly from the other variables' range constraints, querying each one only once. Output-identical. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid materializing a solved expression per variable via
try_solve_for. Instead compute each variable's implied range constraint directly from the other variables' range constraints, querying each one only once. Output-identical.On my machine, this improves the wasm reth apc benchmark by ~1.96× on main, and on top of #3781 by ~1.45×