Open
Conversation
vin0401
reviewed
Apr 17, 2026
| return ( | ||
| <OperationalGridProvider | ||
| columns={ columns } | ||
| disableCsvImport={ disableCsvImport } |
Collaborator
There was a problem hiding this comment.
Randomly came across this one. It feels a bit strange to see these changes directly in the operational grid. Can't we just an button that then consumes the necessary information from the context instead?
At least I wouldn't change the behavior of the operational grid here, since it does not feel like something that is directly connected to the API of the grid.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Changes in this pull request
Resolves #3165
Additional info
This pull request introduces a CSV import feature to the Operational Grid component, allowing users to import and edit grid data via a CSV modal dialog. The feature can be enabled or disabled via a prop, and includes UI integration, context wiring, and localization.
CSV Import Feature Integration:
CsvImportModalReact component for editing grid data as CSV, with conversion logic between rows and CSV text.useOperationshook to manage the CSV import modal's open state, handle confirmation/cancellation, and exposeopenCsvImportandcsvImportModalfor use in UI components. [1] [2] [3] [4]Component and Storybook Updates:
Configuration and Context Wiring:
disableCsvImportprop toOperationalGridPropsand passed it through the context provider, allowing feature toggling at the component level. [1] [2] [3]Localization: