PMM-15130 Validate connection on agent params change

admin/commands/inventory/change_agent_external_exporter.go

@@ -72,6 +72,9 @@ type ChangeAgentExternalExporterCommand struct {
 
 	// Custom labels
 	CustomLabels *map[string]string `mapsep:"," help:"Custom user-assigned labels"`
+
+	// Connection check
+	SkipConnectionCheck *bool `help:"Skip connection check"`
 }
 
 // RunCmd executes the ChangeAgentExternalExporterCommand and returns the result.
@@ -82,12 +85,13 @@ func (cmd *ChangeAgentExternalExporterCommand) RunCmd() (commands.Result, error)
 	customLabels := commands.ParseKeyValuePair(cmd.CustomLabels)
 
 	body := &agents.ChangeAgentParamsBodyExternalExporter{
-		Enable:            cmd.Enable,
-		Username:          cmd.Username,
-		ListenPort:        cmd.ListenPort,
-		Scheme:            cmd.MetricsScheme,
-		MetricsPath:       cmd.MetricsPath,
-		EnablePushMetrics: cmd.PushMetrics,
+		Enable:              cmd.Enable,
+		Username:            cmd.Username,
+		ListenPort:          cmd.ListenPort,
+		Scheme:              cmd.MetricsScheme,
+		MetricsPath:         cmd.MetricsPath,
+		EnablePushMetrics:   cmd.PushMetrics,
+		SkipConnectionCheck: cmd.SkipConnectionCheck,
 	}
 
 	if customLabels != nil {

admin/commands/inventory/change_agent_mongodb_exporter.go

@@ -97,6 +97,9 @@ type ChangeAgentMongodbExporterCommand struct {
 
 	// Custom labels
 	CustomLabels *map[string]string `mapsep:"," help:"Custom user-assigned labels"`
+
+	// Connection check
+	SkipConnectionCheck *bool `help:"Skip connection check"`
 }
 
 // RunCmd executes the ChangeAgentMongodbExporterCommand and returns the result.
@@ -155,6 +158,7 @@ func (cmd *ChangeAgentMongodbExporterCommand) RunCmd() (commands.Result, error)
 		EnablePushMetrics:             cmd.PushMetrics,
 		LogLevel:                      convertLogLevelPtr(cmd.LogLevel),
 		ConnectionTimeout:             commands.DurationString(cmd.ConnectionTimeout),
+		SkipConnectionCheck:           cmd.SkipConnectionCheck,
 	}
 
 	if customLabels != nil {

admin/commands/inventory/change_agent_mysqld_exporter.go

@@ -91,6 +91,9 @@ type ChangeAgentMysqldExporterCommand struct {
 
 	// Custom labels
 	CustomLabels *map[string]string `mapsep:"," help:"Custom user-assigned labels"`
+
+	// Connection check
+	SkipConnectionCheck *bool `help:"Skip connection check"`
 }
 
 // RunCmd executes the ChangeAgentMysqldExporterCommand and returns the result.
@@ -146,6 +149,7 @@ func (cmd *ChangeAgentMysqldExporterCommand) RunCmd() (commands.Result, error) {
 		EnablePushMetrics:         cmd.PushMetrics,
 		LogLevel:                  convertLogLevelPtr(cmd.LogLevel),
 		ConnectionTimeout:         commands.DurationString(cmd.ConnectionTimeout),
+		SkipConnectionCheck:       cmd.SkipConnectionCheck,
 	}
 
 	if customLabels != nil {

admin/commands/inventory/change_agent_mysqld_exporter_test.go

@@ -341,6 +341,41 @@ Configuration changes applied:
 		assert.JSONEq(t, expectedJSON, capturedRequestBody)
 	})
 
+	t.Run("KongParsingWithSkipConnectionCheck", func(t *testing.T) {
+		agentID := "test-mysqld-skip"
+
+		var capturedRequestBody string
+
+		cleanup := setupChangeAgentTestServer(t, agentID, "", &capturedRequestBody)
+		defer cleanup()
+
+		var cmd ChangeAgentMysqldExporterCommand
+		parser := kong.Must(&cmd)
+
+		args := []string{agentID, "--skip-connection-check"}
+
+		ctx, err := parser.Parse(args)
+		require.NoError(t, err)
+		require.NotNil(t, ctx)
+
+		require.NotNil(t, cmd.SkipConnectionCheck)
+		assert.True(t, *cmd.SkipConnectionCheck)
+
+		result, err := cmd.RunCmd()
+		require.NoError(t, err)
+		require.NotNil(t, result)
+
+		// Positive counterpart to KongParsingWithMinimalFlags: when the flag IS passed,
+		// the request body must carry skip_connection_check: true (not omitted).
+		expectedJSON := `{
+			"mysqld_exporter": {
+				"disable_collectors": null,
+				"skip_connection_check": true
+			}
+		}`
+		assert.JSONEq(t, expectedJSON, capturedRequestBody)
+	})
+
 	t.Run("KongParsingErrorCases", func(t *testing.T) {
 		t.Run("MissingRequiredArgument", func(t *testing.T) {
 			var cmd ChangeAgentMysqldExporterCommand

admin/commands/inventory/change_agent_postgres_exporter.go

@@ -92,6 +92,9 @@ type ChangeAgentPostgresExporterCommand struct {
 
 	// Custom labels
 	CustomLabels *map[string]string `mapsep:"," help:"Custom user-assigned labels"`
+
+	// Connection check
+	SkipConnectionCheck *bool `help:"Skip connection check"`
 }
 
 // RunCmd executes the ChangeAgentPostgresExporterCommand and returns the result.
@@ -148,6 +151,7 @@ func (cmd *ChangeAgentPostgresExporterCommand) RunCmd() (commands.Result, error)
 		MaxExporterConnections: cmd.MaxExporterConnections,
 		LogLevel:               convertLogLevelPtr(cmd.LogLevel),
 		ConnectionTimeout:      commands.DurationString(cmd.ConnectionTimeout),
+		SkipConnectionCheck:    cmd.SkipConnectionCheck,
 	}
 
 	if customLabels != nil {

admin/commands/inventory/change_agent_proxysql_exporter.go

@@ -87,6 +87,9 @@ type ChangeAgentProxysqlExporterCommand struct {
 
 	// Custom labels
 	CustomLabels *map[string]string `mapsep:"," help:"Custom user-assigned labels"`
+
+	// Connection check
+	SkipConnectionCheck *bool `help:"Skip connection check"`
 }
 
 // RunCmd executes the ChangeAgentProxysqlExporterCommand and returns the result.
@@ -97,17 +100,18 @@ func (cmd *ChangeAgentProxysqlExporterCommand) RunCmd() (commands.Result, error)
 	customLabels := commands.ParseKeyValuePair(cmd.CustomLabels)
 
 	body := &agents.ChangeAgentParamsBodyProxysqlExporter{
-		Enable:            cmd.Enable,
-		Username:          cmd.Username,
-		Password:          cmd.Password,
-		TLS:               cmd.TLS,
-		TLSSkipVerify:     cmd.TLSSkipVerify,
-		DisableCollectors: cmd.DisableCollectors,
-		AgentPassword:     cmd.AgentPassword,
-		ExposeExporter:    cmd.ExposeExporter,
-		EnablePushMetrics: cmd.PushMetrics,
-		LogLevel:          convertLogLevelPtr(cmd.LogLevel),
-		ConnectionTimeout: commands.DurationString(cmd.ConnectionTimeout),
+		Enable:              cmd.Enable,
+		Username:            cmd.Username,
+		Password:            cmd.Password,
+		TLS:                 cmd.TLS,
+		TLSSkipVerify:       cmd.TLSSkipVerify,
+		DisableCollectors:   cmd.DisableCollectors,
+		AgentPassword:       cmd.AgentPassword,
+		ExposeExporter:      cmd.ExposeExporter,
+		EnablePushMetrics:   cmd.PushMetrics,
+		LogLevel:            convertLogLevelPtr(cmd.LogLevel),
+		ConnectionTimeout:   commands.DurationString(cmd.ConnectionTimeout),
+		SkipConnectionCheck: cmd.SkipConnectionCheck,
 	}
 
 	if customLabels != nil {

admin/commands/inventory/change_agent_qan_mongodb_mongolog_agent.go

@@ -86,6 +86,9 @@ type ChangeAgentQANMongoDBMongologAgentCommand struct {
 
 	// Custom labels
 	CustomLabels *map[string]string `mapsep:"," help:"Custom user-assigned labels"`
+
+	// Connection check
+	SkipConnectionCheck *bool `help:"Skip connection check"`
 }
 
 // RunCmd executes the ChangeAgentQANMongoDBMongologAgentCommand and returns the result.
@@ -126,6 +129,7 @@ func (cmd *ChangeAgentQANMongoDBMongologAgentCommand) RunCmd() (commands.Result,
 		AuthenticationMechanism:       cmd.AuthenticationMechanism,
 		AuthenticationDatabase:        cmd.AuthenticationDatabase,
 		LogLevel:                      convertLogLevelPtr(cmd.LogLevel),
+		SkipConnectionCheck:           cmd.SkipConnectionCheck,
 	}
 
 	// Parse custom labels if provided

admin/commands/inventory/change_agent_qan_mongodb_profiler_agent.go

@@ -87,6 +87,9 @@ type ChangeAgentQANMongoDBProfilerAgentCommand struct {
 
 	// Custom labels
 	CustomLabels *map[string]string `mapsep:"," help:"Custom user-assigned labels"`
+
+	// Connection check
+	SkipConnectionCheck *bool `help:"Skip connection check"`
 }
 
 // RunCmd executes the ChangeAgentQANMongoDBProfilerAgentCommand and returns the result.
@@ -130,6 +133,7 @@ func (cmd *ChangeAgentQANMongoDBProfilerAgentCommand) RunCmd() (commands.Result,
 		AuthenticationDatabase:        cmd.AuthenticationDatabase,
 		MaxQueryLength:                cmd.MaxQueryLength,
 		LogLevel:                      convertLogLevelPtr(cmd.LogLevel),
+		SkipConnectionCheck:           cmd.SkipConnectionCheck,
 	}
 
 	if customLabels != nil {

admin/commands/inventory/change_agent_qan_mysql_perfschema_agent.go

@@ -84,6 +84,9 @@ type ChangeAgentQANMySQLPerfSchemaAgentCommand struct {
 
 	// Custom labels
 	CustomLabels *map[string]string `mapsep:"," help:"Custom user-assigned labels"`
+
+	// Connection check
+	SkipConnectionCheck *bool `help:"Skip connection check"`
 }
 
 // RunCmd executes the ChangeAgentQANMySQLPerfSchemaAgentCommand and returns the result.
@@ -135,6 +138,7 @@ func (cmd *ChangeAgentQANMySQLPerfSchemaAgentCommand) RunCmd() (commands.Result,
 		DisableQueryExamples:   cmd.DisableQueryExamples,
 		DisableCommentsParsing: cmd.CommentsParsingDisabled(),
 		LogLevel:               convertLogLevelPtr(cmd.LogLevel),
+		SkipConnectionCheck:    cmd.SkipConnectionCheck,
 	}
 
 	if customLabels != nil {

admin/commands/inventory/change_agent_qan_mysql_slowlog_agent.go

@@ -85,6 +85,9 @@ type ChangeAgentQANMySQLSlowlogAgentCommand struct {
 
 	// Custom labels
 	CustomLabels *map[string]string `mapsep:"," help:"Custom user-assigned labels"`
+
+	// Connection check
+	SkipConnectionCheck *bool `help:"Skip connection check"`
 }
 
 // RunCmd executes the ChangeAgentQANMySQLSlowlogAgentCommand and returns the result.
@@ -135,6 +138,7 @@ func (cmd *ChangeAgentQANMySQLSlowlogAgentCommand) RunCmd() (commands.Result, er
 		DisableQueryExamples:   cmd.DisableQueryExamples,
 		DisableCommentsParsing: cmd.CommentsParsingDisabled(),
 		LogLevel:               convertLogLevelPtr(cmd.LogLevel),
+		SkipConnectionCheck:    cmd.SkipConnectionCheck,
 	}
 
 	if customLabels != nil {

admin/commands/inventory/change_agent_qan_postgresql_pgstatements_agent.go

@@ -85,6 +85,9 @@ type ChangeAgentQANPostgreSQLPgStatementsAgentCommand struct {
 
 	// Custom labels
 	CustomLabels *map[string]string `mapsep:"," help:"Custom user-assigned labels"`
+
+	// Connection check
+	SkipConnectionCheck *bool `help:"Skip connection check"`
 }
 
 // RunCmd executes the ChangeAgentQANPostgreSQLPgStatementsAgentCommand and returns the result.
@@ -133,6 +136,7 @@ func (cmd *ChangeAgentQANPostgreSQLPgStatementsAgentCommand) RunCmd() (commands.
 		MaxQueryLength:         cmd.MaxQueryLength,
 		DisableCommentsParsing: cmd.CommentsParsingDisabled(),
 		LogLevel:               convertLogLevelPtr(cmd.LogLevel),
+		SkipConnectionCheck:    cmd.SkipConnectionCheck,
 	}
 
 	if customLabels != nil {

admin/commands/inventory/change_agent_qan_postgresql_pgstatmonitor_agent.go

@@ -87,6 +87,9 @@ type ChangeAgentQANPostgreSQLPgStatMonitorAgentCommand struct {
 
 	// Custom labels
 	CustomLabels *map[string]string `mapsep:"," help:"Custom user-assigned labels"`
+
+	// Connection check
+	SkipConnectionCheck *bool `help:"Skip connection check"`
 }
 
 // RunCmd executes the ChangeAgentQANPostgreSQLPgStatMonitorAgentCommand and returns the result.
@@ -136,6 +139,7 @@ func (cmd *ChangeAgentQANPostgreSQLPgStatMonitorAgentCommand) RunCmd() (commands
 		DisableQueryExamples:   cmd.DisableQueryExamples,
 		DisableCommentsParsing: cmd.CommentsParsingDisabled(),
 		LogLevel:               convertLogLevelPtr(cmd.LogLevel),
+		SkipConnectionCheck:    cmd.SkipConnectionCheck,
 	}
 
 	if customLabels != nil {

admin/commands/inventory/change_agent_rta_mongodb.go

@@ -86,6 +86,9 @@ type ChangeAgentRTAMongoDBAgentCommand struct {
 
 	// Custom labels
 	CustomLabels *map[string]string `mapsep:"," help:"Custom user-assigned labels"`
+
+	// Connection check
+	SkipConnectionCheck *bool `help:"Skip connection check"`
 }
 
 // RunCmd executes the ChangeAgentRTAMongoDBAgentCommand and returns the result.
@@ -127,6 +130,7 @@ func (cmd *ChangeAgentRTAMongoDBAgentCommand) RunCmd() (commands.Result, error)
 		TLSCa:                         tlsCa,
 		AuthenticationMechanism:       cmd.AuthenticationMechanism,
 		LogLevel:                      convertLogLevelPtr(cmd.LogLevel),
+		SkipConnectionCheck:           cmd.SkipConnectionCheck,
 	}
 
 	if customLabels != nil {

admin/commands/inventory/change_agent_valkey_exporter.go

@@ -89,6 +89,9 @@ type ChangeAgentValkeyExporterCommand struct {
 
 	// Custom labels
 	CustomLabels *map[string]string `mapsep:"," help:"Custom user-assigned labels"`
+
+	// Connection check
+	SkipConnectionCheck *bool `help:"Skip connection check"`
 }
 
 // RunCmd executes the ChangeAgentValkeyExporterCommand and returns the result.
@@ -126,20 +129,21 @@ func (cmd *ChangeAgentValkeyExporterCommand) RunCmd() (commands.Result, error) {
 	}
 
 	body := &agents.ChangeAgentParamsBodyValkeyExporter{
-		Enable:            cmd.Enable,
-		Username:          cmd.Username,
-		Password:          cmd.Password,
-		TLS:               cmd.TLS,
-		TLSSkipVerify:     cmd.TLSSkipVerify,
-		AgentPassword:     cmd.AgentPassword,
-		TLSCa:             tlsCa,
-		TLSCert:           tlsCert,
-		TLSKey:            tlsKey,
-		DisableCollectors: cmd.DisableCollectors,
-		ExposeExporter:    cmd.ExposeExporter,
-		EnablePushMetrics: cmd.PushMetrics,
-		LogLevel:          convertLogLevelPtr(cmd.LogLevel),
-		ConnectionTimeout: commands.DurationString(cmd.ConnectionTimeout),
+		Enable:              cmd.Enable,
+		Username:            cmd.Username,
+		Password:            cmd.Password,
+		TLS:                 cmd.TLS,
+		TLSSkipVerify:       cmd.TLSSkipVerify,
+		AgentPassword:       cmd.AgentPassword,
+		TLSCa:               tlsCa,
+		TLSCert:             tlsCert,
+		TLSKey:              tlsKey,
+		DisableCollectors:   cmd.DisableCollectors,
+		ExposeExporter:      cmd.ExposeExporter,
+		EnablePushMetrics:   cmd.PushMetrics,
+		LogLevel:            convertLogLevelPtr(cmd.LogLevel),
+		ConnectionTimeout:   commands.DurationString(cmd.ConnectionTimeout),
+		SkipConnectionCheck: cmd.SkipConnectionCheck,
 	}
 
 	if customLabels != nil {

api-tests/inventory/agents_external_exporter_test.go

@@ -453,7 +453,8 @@ func TestExternalExporter(t *testing.T) {
 			AgentID: agentID,
 			Body: agents.ChangeAgentBody{
 				ExternalExporter: &agents.ChangeAgentParamsBodyExternalExporter{
-					Username: new("rotated-external-user"),
+					SkipConnectionCheck: new(true),
+					Username:            new("rotated-external-user"),
 				},
 			},
 			Context: pmmapitests.Context,
@@ -467,8 +468,9 @@ func TestExternalExporter(t *testing.T) {
 			AgentID: agentID,
 			Body: agents.ChangeAgentBody{
 				ExternalExporter: &agents.ChangeAgentParamsBodyExternalExporter{
-					Scheme:      new("http"),
-					MetricsPath: new("/new-metrics"),
+					SkipConnectionCheck: new(true),
+					Scheme:              new("http"),
+					MetricsPath:         new("/new-metrics"),
 				},
 			},
 			Context: pmmapitests.Context,
@@ -527,7 +529,8 @@ func TestExternalExporter(t *testing.T) {
 			AgentID: agentID,
 			Body: agents.ChangeAgentBody{
 				ExternalExporter: &agents.ChangeAgentParamsBodyExternalExporter{
-					Username: new("changed-external-user"),
+					SkipConnectionCheck: new(true),
+					Username:            new("changed-external-user"),
 					// Note: custom labels, scheme, metrics path, push metrics are NOT specified
 				},
 			},
@@ -598,10 +601,11 @@ func TestExternalExporter(t *testing.T) {
 			AgentID: agentID,
 			Body: agents.ChangeAgentBody{
 				ExternalExporter: &agents.ChangeAgentParamsBodyExternalExporter{
-					Username:    new("changed-external-user"),
-					Scheme:      new("https"),
-					MetricsPath: new("/new-metrics"),
-					ListenPort:  new(int64(8080)),
+					SkipConnectionCheck: new(true),
+					Username:            new("changed-external-user"),
+					Scheme:              new("https"),
+					MetricsPath:         new("/new-metrics"),
+					ListenPort:          new(int64(8080)),
 					CustomLabels: &agents.ChangeAgentParamsBodyExternalExporterCustomLabels{
 						Values: map[string]string{
 							"environment": "production",