PMM-15130 Validate connection on agent params change#5618
Merged
4nte merged 19 commits intoJul 15, 2026
Conversation
…s-update Resolve conflicts between skip_connection_check (this PR) and main's new connection_timeout field/flag on the Change* exporter messages and CLI: - agents.proto: keep both fields; move skip_connection_check to 14 (ChangeProxySQLExporterParams) and 17 (ChangeValkeyExporterParams) to avoid colliding with connection_timeout at 13/16. - 5 change_agent_*_exporter.go CLI files: keep both ConnectionTimeout and SkipConnectionCheck wiring. - Regenerate inventory generated files (agents.pb.go, change_agent_responses.go, v1.json, swagger.json, swagger-dev.json) from the merged proto. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5618 +/- ##
==========================================
+ Coverage 43.59% 44.44% +0.84%
==========================================
Files 415 416 +1
Lines 43134 43136 +2
==========================================
+ Hits 18804 19170 +366
+ Misses 22454 22091 -363
+ Partials 1876 1875 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4nte
requested review from
JiriCtvrtka,
ademidoff and
maxkondr
and removed request for
a team
ademidoff
approved these changes
Jul 10, 2026
Member
|
I think we need to document well this feature for those who's agent 1) lost the password or 2) is in the maintenance window or just down for some reason. Clearly, the agent won't be able to verify the password, so documenting something like "please pass the skipConnectionCheck = true " if such case would be great. |
maxkondr
reviewed
Jul 10, 2026
maxkondr
reviewed
Jul 13, 2026
maxkondr
approved these changes
Jul 13, 2026
JiriCtvrtka
approved these changes
Jul 13, 2026
ademidoff
temporarily deployed
to
PMM-15130-validate-connection-on-agent-params-update - pmm-doc-3 PR #5618
Render
Destroyed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-15130
Feature Build
When a change touches connection parameters (username, password, TLS options, etc.), pmm-managed now verifies the new settings by having the pmm-agent connect to the service (with changed params). If the check fails, the change is rolled back and the agent keeps its previous working config.
User has an option to opt-out via
--skip-connection-checkto bypass validation.