Fix missing volume checks in material activity/decay heat#3939
Merged
Conversation
nuclearkevin
approved these changes
May 17, 2026
Member
There was a problem hiding this comment.
Thanks for this contribution, and welcome to the OpenMC community @approx-infinity! This looks good to me; if nobody else has any comments I'll merge tomorrow.
paulromano
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds explicit validation for Material.volume in total activity (Bq, Ci) and decay heat (W) calculations.
Previously, calling get_activity() or get_decay_heat() without setting a material volume could result in unclear or misleading runtime errors (e.g., TypeError or downstream failures).
This change introduces a clear and early ValueError when volume is not defined, improving error clarity and robustness of the material depletion/decay interface.
Changes
-- total activity
-- total decay heat
Testing
pytest tests/unit_tests/test_material.py -k "get_activity or get_decay_heat"
Result
2 passed, 35 deselected
Checklist