GenAI Utils | Add metrics to ToolInvocations#4443
Open
keith-decker wants to merge 10 commits intoopen-telemetry:mainfrom
Open
GenAI Utils | Add metrics to ToolInvocations#4443keith-decker wants to merge 10 commits intoopen-telemetry:mainfrom
keith-decker wants to merge 10 commits intoopen-telemetry:mainfrom
Conversation
lmolkova
reviewed
Apr 16, 2026
Member
lmolkova
left a comment
lmolkova
left a comment
There was a problem hiding this comment.
LGTM, the only concern is provider, service attributes - we won't have them in semconv on tool calls and we won't really be able to populate them either in instrumentations
JWinermaSplunk
approved these changes
Apr 16, 2026
JWinermaSplunk
left a comment
JWinermaSplunk
left a comment
There was a problem hiding this comment.
LGTM as well, though I agree with @lmolkova's comment
11 tasks
lmolkova
approved these changes
Apr 16, 2026
6 tasks
eternalcuriouslearner
approved these changes
Apr 17, 2026
Contributor
eternalcuriouslearner
left a comment
eternalcuriouslearner
left a comment
There was a problem hiding this comment.
LGTM!! Sorry for being pedantic but left a nit to see we can remove the pylint.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds duration metrics to ToolInvocations
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.