feat(langchain): enhance span manager and add event emitter [3/5]#4452
Open
nagkumar91 wants to merge 3 commits intoopen-telemetry:mainfrom
Open
feat(langchain): enhance span manager and add event emitter [3/5]#4452nagkumar91 wants to merge 3 commits intoopen-telemetry:mainfrom
nagkumar91 wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
…nt recording modules Add foundation modules for enhanced LangChain GenAI semantic convention tracing: - semconv_attributes.py: Per-operation attribute matrix based on OTel GenAI semantic conventions. Single source of truth for which attributes apply to which operations (chat, text_completion, invoke_agent, execute_tool, invoke_workflow, retrieval). - operation_mapping.py: Callback-to-semconv operation mapping. Maps each LangChain callback to the correct GenAI semantic convention operation name. Includes heuristic classification for on_chain_start callbacks (agents vs workflows vs internal plumbing) and LangGraph marker recognition. - content_recording.py: Thin integration layer over the shared genai content capture utilities. Provides clear APIs for the callback handler to decide what content should be recorded on spans and events. Part 1 of a series breaking down open-telemetry#4389 into smaller reviewable PRs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…propagation utilities Add utility modules for the LangChain instrumentor: - utils.py: Provider name inference from LangChain callback data (ls_provider, base_url, class name, endpoint fields), server address/port extraction, and W3C trace context header extraction and propagation support. - message_formatting.py: Message, tool, and document serialization with content-redaction support. Converts LangChain message objects into the compact JSON format expected by OpenTelemetry GenAI semantic conventions. Part 2 of a series breaking down open-telemetry#4389 into smaller reviewable PRs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Enhance the span lifecycle manager and add event emission for non-LLM GenAI operations: - span_manager.py: Enhanced with ignored-run walkthrough (re-parenting children of skipped internal runs), per-thread agent stacks for hierarchy tracking, token usage accumulation and propagation to parent agent spans, and LangGraph Command(goto=...) transition support. - event_emitter.py: Emits semantic-convention-aligned log-record events for tool, agent, and retriever spans. All event emission is gated behind the content policy. Uses LogRecord instances linked to the active span context. Part 3 of a series breaking down open-telemetry#4389 into smaller reviewable PRs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
eternalcuriouslearner
left a comment
eternalcuriouslearner
left a comment
There was a problem hiding this comment.
Howdy @nagkumar91, I believe some of the functionality implemented in this PR is already being built in the util-genai package. Specifically, ToolInvocation metrics in #4443 and AgentInvocation type in #4274 overlap with the custom event_emitter.py and span_manager.py here. Can you please take a look at those PRs and see if we can reuse them to simplify this one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhance the span lifecycle manager with advanced hierarchy tracking and add event emission for non-LLM GenAI operations.
Changes
span_manager.py(enhanced)invoke_agentspan hierarchies across concurrent execution threadsCommand(goto=...)transitions to maintain correct parent contextevent_emitter.py(new)LogRecordevents for tool, agent, and retriever spansgen_ai.tool.call,gen_ai.tool.result,gen_ai.agent.start,gen_ai.agent.finish,gen_ai.retriever.query,gen_ai.retriever.resultOTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT/OTEL_INSTRUMENTATION_GENAI_EMIT_EVENT)Tests
test_span_hierarchy.py— ignored-run re-parenting, agent stack tracking, parent resolutiontest_usage_propagation.py— token accumulation across span hierarchiestest_event_emitter.py— event emission with content recording on/offPR Series
This is PR 3 of 5 breaking down #4389:
Depends on: #4451 (merge first)
Type of change
Checklist