fix(receiver/httpcheck): report timing metrics as float64 to preserve sub-millisecond precision#47718
Open
himanshu130700 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
himanshu130700
force-pushed
the
fix/47257-httpcheck-timing-metrics-zero
branch
2 times, most recently
from
f3179db to
511650a
Compare
… sub-millisecond precision
himanshu130700
force-pushed
the
fix/47257-httpcheck-timing-metrics-zero
branch
from
511650a to
f1acef6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47257
Previously, getDurations() used integer division (ns / int64(time.Millisecond))
which truncated any phase duration under 1ms to 0. On fast local/Docker networks,
all five phase timings (DNS, TCP connect, TLS handshake, request write, response
read) are typically sub-millisecond, causing the metrics to always report 0.
Fix by changing the five affected timing metrics to value_type: double in
metadata.yaml and using float64 division in getDurations(), so e.g. a 500µs
DNS lookup is correctly reported as 0.5ms instead of 0ms.