fix(receiver/httpcheck): report timing metrics as float64 to preserve sub-millisecond precision

Author: himanshu130700

.chloggen/fix-47257-httpcheck-timing-metrics-zero.yaml

@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: bug_fix
+
+# The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog)
+component: receiver/httpcheck
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: "Fix timing metrics (`httpcheck.dns.lookup.duration`, `httpcheck.client.connection.duration`, `httpcheck.tls.handshake.duration`, `httpcheck.client.request.duration`, `httpcheck.response.duration`) always reporting 0 on fast networks where phase durations are sub-millisecond."
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [47257]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext: "Integer division truncated sub-millisecond durations to 0. Metrics are now reported as float64 (milliseconds with decimal precision)."
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [user]

receiver/httpcheckreceiver/documentation.md

@@ -74,7 +74,7 @@ Time spent establishing TCP connection to the endpoint.
 
 | Unit | Metric Type | Value Type | Stability |
 | ---- | ----------- | ---------- | --------- |
-| ms | Gauge | Int | Development |
+| ms | Gauge | Double | Development |
 
 #### Attributes
 
@@ -89,7 +89,7 @@ Time spent sending the HTTP request to the endpoint.
 
 | Unit | Metric Type | Value Type | Stability |
 | ---- | ----------- | ---------- | --------- |
-| ms | Gauge | Int | Development |
+| ms | Gauge | Double | Development |
 
 #### Attributes
 
@@ -103,7 +103,7 @@ Time spent performing DNS lookup for the endpoint.
 
 | Unit | Metric Type | Value Type | Stability |
 | ---- | ----------- | ---------- | --------- |
-| ms | Gauge | Int | Development |
+| ms | Gauge | Double | Development |
 
 #### Attributes
 
@@ -117,7 +117,7 @@ Time spent receiving the HTTP response from the endpoint.
 
 | Unit | Metric Type | Value Type | Stability |
 | ---- | ----------- | ---------- | --------- |
-| ms | Gauge | Int | Development |
+| ms | Gauge | Double | Development |
 
 #### Attributes
 
@@ -162,7 +162,7 @@ Time spent performing TLS handshake with the endpoint.
 
 | Unit | Metric Type | Value Type | Stability |
 | ---- | ----------- | ---------- | --------- |
-| ms | Gauge | Int | Development |
+| ms | Gauge | Double | Development |
 
 #### Attributes
 

receiver/httpcheckreceiver/generated_package_test.go

@@ -56,23 +56,23 @@ metrics:
     enabled: false
     stability: development
     gauge:
-      value_type: int
+      value_type: double
     unit: ms
     attributes: [http.url, network.transport]
   httpcheck.client.request.duration:
     description: Time spent sending the HTTP request to the endpoint.
     enabled: false
     stability: development
     gauge:
-      value_type: int
+      value_type: double
     unit: ms
     attributes: [http.url]
   httpcheck.dns.lookup.duration:
     description: Time spent performing DNS lookup for the endpoint.
     enabled: false
     stability: development
     gauge:
-      value_type: int
+      value_type: double
     unit: ms
     attributes: [http.url]
   httpcheck.duration:
@@ -98,7 +98,7 @@ metrics:
     enabled: false
     stability: development
     gauge:
-      value_type: int
+      value_type: double
     unit: ms
     attributes: [http.url]
   httpcheck.response.size:
@@ -132,7 +132,7 @@ metrics:
     enabled: false
     stability: development
     gauge:
-      value_type: int
+      value_type: double
     unit: ms
     attributes: [http.url]
   httpcheck.validation.failed:

receiver/httpcheckreceiver/internal/metadata/generated_config_test.go

@@ -48,36 +48,36 @@ type timingInfo struct {
 	responseStart atomic.Int64
 }
 
-// getDurations calculates the duration for each phase in milliseconds
-func (t *timingInfo) getDurations() (dnsMs, tcpMs, tlsMs, requestMs, responseMs int64) {
+// getDurations calculates the duration for each phase in milliseconds.
+func (t *timingInfo) getDurations() (dnsMs, tcpMs, tlsMs, requestMs, responseMs float64) {
 	dnsStartNs := t.dnsStart.Load()
 	dnsEndNs := t.dnsEnd.Load()
 	if dnsStartNs != 0 && dnsEndNs != 0 {
-		dnsMs = (dnsEndNs - dnsStartNs) / int64(time.Millisecond)
+		dnsMs = float64(dnsEndNs-dnsStartNs) / float64(time.Millisecond)
 	}
 
 	connectStartNs := t.connectStart.Load()
 	connectEndNs := t.connectEnd.Load()
 	if connectStartNs != 0 && connectEndNs != 0 {
-		tcpMs = (connectEndNs - connectStartNs) / int64(time.Millisecond)
+		tcpMs = float64(connectEndNs-connectStartNs) / float64(time.Millisecond)
 	}
 
 	tlsStartNs := t.tlsStart.Load()
 	tlsEndNs := t.tlsEnd.Load()
 	if tlsStartNs != 0 && tlsEndNs != 0 {
-		tlsMs = (tlsEndNs - tlsStartNs) / int64(time.Millisecond)
+		tlsMs = float64(tlsEndNs-tlsStartNs) / float64(time.Millisecond)
 	}
 
 	writeStartNs := t.writeStart.Load()
 	writeEndNs := t.writeEnd.Load()
 	if writeStartNs != 0 && writeEndNs != 0 {
-		requestMs = (writeEndNs - writeStartNs) / int64(time.Millisecond)
+		requestMs = float64(writeEndNs-writeStartNs) / float64(time.Millisecond)
 	}
 
 	readStartNs := t.readStart.Load()
 	readEndNs := t.readEnd.Load()
 	if readStartNs != 0 && readEndNs != 0 {
-		responseMs = (readEndNs - readStartNs) / int64(time.Millisecond)
+		responseMs = float64(readEndNs-readStartNs) / float64(time.Millisecond)
 	}
 
 	return dnsMs, tcpMs, tlsMs, requestMs, responseMs