Skip to content

[ENH] Add Dev Container#256

Open
bendhouseart wants to merge 10 commits intonipreps:mainfrom
bendhouseart:dev-container
Open

[ENH] Add Dev Container#256
bendhouseart wants to merge 10 commits intonipreps:mainfrom
bendhouseart:dev-container

Conversation

@bendhouseart
Copy link
Copy Markdown
Collaborator

Breaks out dev container from PR #236

Adds dev container setup based on ghrc.io/nipreps/petprep:main

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.06%. Comparing base (7efcfc0) to head (56db3a1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   83.06%   83.06%           
=======================================
  Files          87       87           
  Lines        8177     8177           
  Branches      873      873           
=======================================
  Hits         6792     6792           
  Misses       1163     1163           
  Partials      222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bendhouseart
Copy link
Copy Markdown
Collaborator Author

Okay, not sure what's killing the CI, but ran the following: tox -q -- -q --tb=no -r f, and got this:

  py310-latest: OK (821.05 seconds)
  py310-pre: OK (563.00 seconds)
  py311-latest: OK (673.70 seconds)
  py311-pre: OK (616.78 seconds)
  py312-latest: OK (648.87 seconds)
  py312-pre: FAIL code 1 (163.71 seconds)
  py313-latest: FAIL code 1 (21.53 seconds)
  py313-pre: FAIL code 1 (3.26 seconds)
  py310-min: FAIL code 1 (111.14 seconds)

Seems like more of a versioning nightmare than an issue with this PR, but haven't investigated each part of the testing matrix that failed as of yet. Use your own judgement on whether to merge this or not.

@bendhouseart bendhouseart requested a review from mnoergaard March 23, 2026 17:35
@bendhouseart bendhouseart self-assigned this Mar 23, 2026
Comment thread petprep/cli/run.py Outdated
@bendhouseart
Copy link
Copy Markdown
Collaborator Author

Woohoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants