[ENH] Update Filename Entity Order#236
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 83.06% 83.07% +0.01%
==========================================
Files 87 87
Lines 8177 8184 +7
Branches 873 874 +1
==========================================
+ Hits 6792 6799 +7
Misses 1163 1163
Partials 222 222 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for opening this PR @bendhouseart. However, it is currently mixing several things together, and it would be better have several PRs addressing each issue.
Many thanks! |
1 similar comment
… into update-entity-order
|
Suggestions applied; will re-tag for review after CI is passing. |
|
@mgxd - do you mind reviewing this? Many thanks |
mgxd
left a comment
There was a problem hiding this comment.
LGTM - would be nice to have a check outputs step in the CI (like we do in other preps) to ensure produced outputs 1) exist and 2) are named appropriately
You'd need to build and import the schema to the validator for BEP 023, but that's not the worst thing to take care of in CI. It would have the knock on effect of quickly exposing whether the spec or petprep was out of date while outputs are mulled over. |
|
I meant essentially an outputs manifest (like https://raw.githubusercontent.com/nipreps/fmriprep/refs/heads/master/.circleci/ds005_outputs.txt) to compare to for the time being. Though agreed it would also be nice to validate outputs occasionally |
I'll be happy to review your PR for that ;) |
Couldn't figure out why changes to niworkflows/data/nipreps.json to address this issue weren't being used here, but got there eventually. Will update the nipreps json at nipreps/niworkflows, but like @effigies or @mgxd mentioned it is probably worth just switching over to the schema instead of relying on these config files.
But I'm also a fan of incremental improvement and small bug fixes.
Changes proposed in this pull request
Adds dev container setup based on ghrc.io/nipreps/petprep:mainremoved and moved to PR [ENH] Add Dev Container #256Documentation that should be reviewed
Couldn't come up with a good place to put this in docs so it's self contained in the devcontainer folder:.devcontainer/README.rst