Implement the EUCM camera model#996
Draft
Ph03n1xdust wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I would like to implement the EUCM camera model as it was already added to COLMAP.
The current version is technically working, but I hijacked the
tangential_coeffsto pass thealphaandbetaparameters of the model, also I did not add the pure python implementation yet. I would like to ask what you think the proper way to pass the extra parameters of potential new camera model should be? I don't believe that inflating therasterizationcall with even more parameters would be the way to go. Should this be fed through the external distortion likeBivariateWindshieldModel?