Skip to content

Fix stress test with name deduping. #40692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kvega005 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −3
Open

Fix stress test with name deduping. #40692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/windows/wslcsession/WSLCVolumes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,6 @@ WSLCVolumeInformation WSLCVolumes::CreateVolume(
auto [it, inserted] = m_volumes.insert({name, std::move(volume)});
WI_VERIFY(inserted);

// Record that we initiated this create so OnVolumeEvent ignores the matching docker event.
m_expectedEvents.emplace_back(name, VolumeEvent::Create);

return info;
}

Expand Down Expand Up @@ -261,6 +258,16 @@ __requires_lock_held(m_lock) void WSLCVolumes::OpenVolumeExclusiveLockHeld(const
{
OpenVolumeExclusiveLockHeld(m_dockerClient.InspectVolume(volumeName));
}
catch (const DockerHTTPException& e)
{
// A 404 here is expected when a late `create` event arrives after the volume has already
// been deleted (e.g. user calls CreateVolume then DeleteVolume; the create event from
// docker can race in after the delete has been processed).
if (e.StatusCode() != 404)
{
LOG_CAUGHT_EXCEPTION_MSG("Failed to open volume: %hs", volumeName.c_str());
}
}
CATCH_LOG_MSG("Failed to open volume: %hs", volumeName.c_str());
}

Expand Down